Page MenuHomePhabricator

[llvm-readelf] Allow prefix flags for -p and -x
ClosedPublic

Authored by rupprecht on Mar 28 2019, 3:00 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

rupprecht created this revision.Mar 28 2019, 3:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 3:00 PM
jhenderson accepted this revision.Mar 29 2019, 2:50 AM

LGTM, with two small comment nits.

llvm/test/tools/llvm-readobj/hexdump.test
7 ↗(On Diff #192723)

-j -> -x?

llvm/test/tools/llvm-readobj/string-dump.test
1 ↗(On Diff #192723)

Might be worth adding a comment to say that you're testing the various different ways of specifying the switches.

This revision is now accepted and ready to land.Mar 29 2019, 2:50 AM
rupprecht updated this revision to Diff 192847.Mar 29 2019, 9:40 AM
rupprecht marked 3 inline comments as done.
  • Update test comments
llvm/test/tools/llvm-readobj/hexdump.test
7 ↗(On Diff #192723)

Yep, I shamelessly copy/paste and forget to update bits like this :)

This revision was automatically updated to reflect the committed changes.