Implements P0919R3.
Details
Diff Detail
Event Timeline
include/__hash_table | ||
---|---|---|
36 | Not quite sure if this is the correct place for this to go, but didn't want to duplicate code. | |
include/unordered_map | ||
428 | Also not sure if this is where this should go. | |
test/std/containers/key_equal.fail.cpp | ||
27 | These comments describe errors in other files. What line should they go on and how should they be formatted? |
Friendly ping. I am waiting on this patch to get done before I submit a patch for precalculated hashes (which is mostly done).
Please hold off on the pre-calculated hashes, since I have been informed that there will be a paper discussed in Cologne about reverting that change (removing that feature).
Here's a few nits; I'm still working on the code.
include/unordered_map | ||
---|---|---|
176 | These all need a comment // C++20 | |
363 | // C++20 comments here too | |
428 | This should go in <version>. Then there's a tool to regenerate the version tests. | |
test/std/containers/key_equal.fail.cpp | ||
27 | You just say expected-error@<filename>:<line number> ; and you can use * for the line number (in fact, you should). |
Not quite sure if this is the correct place for this to go, but didn't want to duplicate code.