This is an archive of the discontinued LLVM Phabricator instance.

[ConstantRange] Exclude full set from isSignWrappedSet()
ClosedPublic

Authored by nikic on Mar 26 2019, 2:46 PM.

Details

Summary

Split off from D59749. This uses a simpler and more efficient implementation of isSignWrappedSet(), and considers full sets as non-wrapped, to be consistent with isWrappedSet(). Otherwise the behavior is unchanged.

There are currently only two users of this function and both already check for isFullSet() || isSignWrappedSet(), so this is not going to cause a change in overall behavior:

lib/IR/ConstantRange.cpp:  if (isFullSet() || isSignWrappedSet()) {
lib/Transforms/Scalar/Float2Int.cpp:        R.isFullSet() || R.isSignWrappedSet())

Diff Detail

Event Timeline

nikic created this revision.Mar 26 2019, 2:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2019, 2:46 PM
lebedev.ri accepted this revision.Mar 26 2019, 2:52 PM

This LG.

This revision is now accepted and ready to land.Mar 26 2019, 2:52 PM
This revision was automatically updated to reflect the committed changes.