This is an archive of the discontinued LLVM Phabricator instance.

Clang thinks "char" is signed when using a thumb triple
ClosedPublic

Authored by olista01 on Oct 24 2014, 3:08 AM.

Download Raw Diff

Details

Reviewers

Summary

'char' is unsigned on all ARM and Thumb architectures. Clang gets this right for ARM, and for thumb when using and arm triple and the -mthumb option, but gets it wrong for thumb triples. This fixes that.

Diff Detail

Event Timeline

olista01 updated this revision to Diff 15388.Oct 24 2014, 3:08 AM

olista01 retitled this revision from to Clang thinks "char" is signed when using a thumb triple.

olista01 updated this object.

olista01 edited the test plan for this revision. (Show Details)

olista01 set the repository for this revision to rL LLVM.

olista01 added a subscriber: Unknown Object (MLST).

Herald added a subscriber: aemerson. · View Herald TranscriptOct 24 2014, 3:08 AM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 24 2014, 4:31 AM

Thanks, committed revision 220555.

Revision Contents

Path

Size

lib/

Driver/

Tools.cpp

2 lines

test/

Lexer/

wchar-signedness.c

1 line

Diff 15388

lib/Driver/Tools.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 453 Lines • ▼ Show 20 Lines	static bool isSignedCharDefault(const llvm::Triple &Triple) {
switch (Triple.getArch()) {		switch (Triple.getArch()) {
default:		default:
return true;		return true;

case llvm::Triple::aarch64:		case llvm::Triple::aarch64:
case llvm::Triple::aarch64_be:		case llvm::Triple::aarch64_be:
case llvm::Triple::arm:		case llvm::Triple::arm:
case llvm::Triple::armeb:		case llvm::Triple::armeb:
		case llvm::Triple::thumb:
		case llvm::Triple::thumbeb:
if (Triple.isOSDarwin() \|\| Triple.isOSWindows())		if (Triple.isOSDarwin() \|\| Triple.isOSWindows())
return true;		return true;
return false;		return false;

case llvm::Triple::ppc:		case llvm::Triple::ppc:
case llvm::Triple::ppc64:		case llvm::Triple::ppc64:
if (Triple.isOSDarwin())		if (Triple.isOSDarwin())
return true;		return true;
▲ Show 20 Lines • Show All 7,647 Lines • Show Last 20 Lines

test/Lexer/wchar-signedness.c

	// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple x86_64-none-linux-gnu \| FileCheck %s --check-prefix=CHECK-X86			// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple x86_64-none-linux-gnu \| FileCheck %s --check-prefix=CHECK-X86
	// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple armv7-none-eabi \| FileCheck %s --check-prefix=CHECK-ARM			// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple armv7-none-eabi \| FileCheck %s --check-prefix=CHECK-ARM
				// RUN: %clang_cc1 -fsyntax-only -dM -E %s -triple thumbv7-none-eabi \| FileCheck %s --check-prefix=CHECK-ARM

	// CHECK-X86-NOT: #define __WCHAR_UNSIGNED__			// CHECK-X86-NOT: #define __WCHAR_UNSIGNED__
	// CHECK-X86: #define __WINT_UNSIGNED__ 1			// CHECK-X86: #define __WINT_UNSIGNED__ 1

	// CHECK-ARM: #define __WCHAR_UNSIGNED__ 1			// CHECK-ARM: #define __WCHAR_UNSIGNED__ 1
	// CHECK-ARM-NOT: #define __WINT_UNSIGNED__ 1			// CHECK-ARM-NOT: #define __WINT_UNSIGNED__ 1