This is an archive of the discontinued LLVM Phabricator instance.

Include stddef.h before including cxxabi.h
ClosedPublic

Authored by ruiu on Oct 23 2014, 12:17 PM.

Details

Reviewers
rafael
Summary

On FreeBSD 10.0, size_t needs to be defined before including cxxabi.h.
Currenty HAVE_CXXABI_H is not defined on FreeBSD because of that reason.
This patch teaches cmake and configure how to include it.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 15340.Oct 23 2014, 12:17 PM
ruiu retitled this revision from to Include stddef.h before including cxxabi.h.
ruiu updated this object.
ruiu edited the test plan for this revision. (Show Details)
ruiu added a reviewer: rafael.
ruiu added a subscriber: Unknown Object (MLST).
joerg added a subscriber: joerg.Oct 23 2014, 1:01 PM

Hm. The regenerated configure looks suspicious, the rest is fine.

autoconf/configure.ac
1596

Move that comment out of the test case, please. Just like you already do for cmake.

ruiu updated this revision to Diff 15344.Oct 23 2014, 1:29 PM
  • Addressed Joerg's comment
ruiu added a comment.Oct 23 2014, 1:32 PM

I installed autoconf 2.60 and automake 1.9.6 and then ran AutoRegen.sh.
The auto-generated configure seems to be working fine.
Not sure why I got this large minus diff.

autoconf/configure.ac
1596

Done

ruiu updated this revision to Diff 15347.Oct 23 2014, 1:54 PM
  • Use dnl instead of // for comment
emaste added a subscriber: emaste.Oct 23 2014, 2:11 PM
rafael accepted this revision.Oct 24 2014, 5:02 AM
rafael edited edge metadata.

I can reproduce the configure change locally.

This revision is now accepted and ready to land.Oct 24 2014, 5:02 AM
ruiu closed this revision.Oct 27 2014, 1:49 AM