Page MenuHomePhabricator

[lldb-vscode] Don't try to launch an invalid program.
ClosedPublic

Authored by jgorbe on Mar 13 2019, 4:21 PM.

Details

Summary

If an invalid program is specified, lldb-vscode will send back a
response with "success": false, but then will continue executing the
rest of request_launch(), try to launch the program anyway and try to
send another response (possibly using the response object after it was
moved).

This change adds a return statement so we stop executing the handler
after producing the first failing response.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

jgorbe created this revision.Mar 13 2019, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2019, 4:21 PM
zturner accepted this revision.Mar 13 2019, 4:45 PM
This revision is now accepted and ready to land.Mar 13 2019, 4:45 PM
This revision was automatically updated to reflect the committed changes.