Page MenuHomePhabricator

[Docs] Add a note about legacy FunctionPassManager to the LLVM tutorial.
ClosedPublic

Authored by kristina on Mar 12 2019, 8:29 AM.

Details

Summary

It seems to confuse some people, I figured it may be worth adding a warning to the tutorial to elaborate and suggest using llvm::legacy::FunctionPassManager for now. Not a perfect solution but hopefully will avoid confusion in the meantime.

Diff Detail

Repository
rL LLVM

Event Timeline

kristina created this revision.Mar 12 2019, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 8:29 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
philip.pfaffe accepted this revision.Mar 12 2019, 8:33 AM
philip.pfaffe added a subscriber: philip.pfaffe.

LGTM. Did you verify that there's no conflicting info in the first three chapters of the tutorial?

This revision is now accepted and ready to land.Mar 12 2019, 8:33 AM

I did, there are no references to any PassManager related material in the first three chapters.

This revision was automatically updated to reflect the committed changes.