[format] \t => ' '

[liangdzou]

Summary

1. \t => ' '
2. test commit access

[liangdzou]

test commit access

[liangdzou]

This comment was removed by liangdzou.

[liangdzou]

For some reason, whitespace change is not shown in this browser. Is this a bug?

[liangdzou]

In D59243#1425763, @liangdzou wrote:

For some reason, whitespace change is not shown in this browser. Is this a bug?

ok, it is commented under the diff: "This file was changed only by adding or removing whitespace."

[Higuoxing]

LGTM :)

[kristina]

Hi,

Please make sure to specify Differential Revision: https://reviews.llvm.org/D59243 with Dxxxxx being the differential number in the URL when committing (on a separate line in the commit message) which will automatically close the differential and link it to the commit which makes sure there are no stray/stale differentials. Alternatively manually link the diff to the commit (you can do that by simply quoting the commit as rL<SVN Rev> and then closing the differential manually.

Also, for future NFC patches, usually very minor formatting patches or spelling fixes don't really require a review, however please make sure to specify the purpose of the patch and mention NFC or NFCI in the title (indicating No Functional Change (Intended)) which makes the patch intention clear. Phabricator is mostly a code review platform so extremely minor corrections in comments or indentation usually don't need review. I'll also add that since it's only a review platform, committing the actual patch after review follows a different procedure (see below), with Phabricator itself not being able to commit patches for you.

You can find more information regarding the submission process here: http://llvm.org/docs/Contributing.html (as well as the developer policy here: http://llvm.org/docs/DeveloperPolicy.html).

Thank you.

llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp

bool NewGVN::runGVN() {
   for (Instruction *ToErase : InstructionsToErase) {
     if (!ToErase->use_empty())
       ToErase->replaceAllUsesWith(UndefValue::get(ToErase->getType()));
 
     assert(ToErase->getParent() &&
            "BB containing ToErase deleted unexpectedly!");
     ToErase->eraseFromParent();
   }
-  Changed |= !InstructionsToErase.empty();
+  Changed |= !InstructionsToErase.empty();
 
   // Delete all unreachable blocks.
   auto UnreachableBlockPred = [&](const BasicBlock &BB) {
     return !ReachableBlocks.count(&BB);
   };
 
   for (auto &BB : make_filter_range(F, UnreachableBlockPred)) {
     LLVM_DEBUG(dbgs() << "We believe block " << getBlockName(&BB)