Page MenuHomePhabricator

[format] \t => ' '
ClosedPublic

Authored by liangdzou on Mar 12 2019, 2:05 AM.

Details

Summary
  1. \t => ' '
  2. test commit access

Diff Detail

Repository
rL LLVM

Event Timeline

liangdzou created this revision.Mar 12 2019, 2:05 AM
liangdzou accepted this revision.Mar 12 2019, 2:06 AM

test commit access

This revision is now accepted and ready to land.Mar 12 2019, 2:06 AM
This comment was removed by liangdzou.

For some reason, whitespace change is not shown in this browser. Is this a bug?

For some reason, whitespace change is not shown in this browser. Is this a bug?

ok, it is commented under the diff: "This file was changed only by adding or removing whitespace."

Higuoxing accepted this revision.Mar 12 2019, 2:25 AM

LGTM :)

kristina added a subscriber: kristina.EditedMar 12 2019, 3:03 AM

Hi,

Please make sure to specify Differential Revision: https://reviews.llvm.org/D59243 with Dxxxxx being the differential number in the URL when committing (on a separate line in the commit message) which will automatically close the differential and link it to the commit which makes sure there are no stray/stale differentials. Alternatively manually link the diff to the commit (you can do that by simply quoting the commit as rL<SVN Rev> and then closing the differential manually.

Also, for future NFC patches, usually very minor formatting patches or spelling fixes don't really require a review, however please make sure to specify the purpose of the patch and mention NFC or NFCI in the title (indicating No Functional Change (Intended)) which makes the patch intention clear. Phabricator is mostly a code review platform so extremely minor corrections in comments or indentation usually don't need review. I'll also add that since it's only a review platform, committing the actual patch after review follows a different procedure (see below), with Phabricator itself not being able to commit patches for you.

You can find more information regarding the submission process here: http://llvm.org/docs/Contributing.html (as well as the developer policy here: http://llvm.org/docs/DeveloperPolicy.html).

Thank you.

Closed by commit rL355924: [format] \t => ' ' (authored by liangdzou, committed by ). · Explain WhyMar 12 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.