This is an archive of the discontinued LLVM Phabricator instance.

Differential D59242

[typo] we we => we
AbandonedPublic

Authored by liangdzou on Mar 12 2019, 1:19 AM.

Details

Reviewers
None
Summary

'we we => we' for the pass earlyCSE

Diff Detail

Event Timeline

liangdzou created this revision.Mar 12 2019, 1:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 1:19 AM
Herald added subscribers: llvm-commits, jfb. · View Herald Transcript
Harbormaster completed remote builds in B29030: Diff 190216.Mar 12 2019, 1:23 AM
Higuoxing added a subscriber: Higuoxing.Mar 12 2019, 1:26 AM

Hi, seems that this patch has been committed in rL355895

liangdzou abandoned this revision.Mar 12 2019, 1:46 AM

sorry, trying arc...

Revision Contents

PathSize
lib/
Transforms/
Scalar/
2 lines

Diff 190216

lib/Transforms/Scalar/EarlyCSE.cpp

Show First 20 Lines • Show All 1,096 Lines • ▼ Show 20 Lines if (Inst->mayWriteToMemory()) {
++CurrentGeneration; ++CurrentGeneration;
if (MemInst.isValid() && MemInst.isStore()) { if (MemInst.isValid() && MemInst.isStore()) {
// We do a trivial form of DSE if there are two stores to the same // We do a trivial form of DSE if there are two stores to the same
// location with no intervening loads. Delete the earlier store. // location with no intervening loads. Delete the earlier store.
// At the moment, we don't remove ordered stores, but do remove // At the moment, we don't remove ordered stores, but do remove
// unordered atomic stores. There's no special requirement (for // unordered atomic stores. There's no special requirement (for
// unordered atomics) about removing atomic stores only in favor of // unordered atomics) about removing atomic stores only in favor of
// other atomic stores since we we're going to execute the non-atomic // other atomic stores since we're going to execute the non-atomic
// one anyway and the atomic one might never have become visible. // one anyway and the atomic one might never have become visible.
if (LastStore) { if (LastStore) {
ParseMemoryInst LastStoreMemInst(LastStore, TTI); ParseMemoryInst LastStoreMemInst(LastStore, TTI);
assert(LastStoreMemInst.isUnordered() && assert(LastStoreMemInst.isUnordered() &&
!LastStoreMemInst.isVolatile() && !LastStoreMemInst.isVolatile() &&
"Violated invariant"); "Violated invariant");
if (LastStoreMemInst.isMatchingMemLoc(MemInst)) { if (LastStoreMemInst.isMatchingMemLoc(MemInst)) {
LLVM_DEBUG(dbgs() << "EarlyCSE DEAD STORE: " << *LastStore LLVM_DEBUG(dbgs() << "EarlyCSE DEAD STORE: " << *LastStore
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines