This is an archive of the discontinued LLVM Phabricator instance.

Differential D59184

[runtime] Use --strip-all rather than --strip-sections
ClosedPublic

Authored by phosek on Mar 9 2019, 6:22 PM.

Details

Reviewers
jakehehrlich
juliehockett
smeenai
Commits
rGb68566aec32d: [runtime] Use --strip-all rather than --strip-sections
rL355783: [runtime] Use --strip-all rather than --strip-sections
Summary

We need to preserve section headers for shared libraries.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Mar 9 2019, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2019, 6:22 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2019, 8:26 PM
Closed by commit rL355783: [runtime] Use --strip-all rather than --strip-sections (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
runtimes/
2 lines

Diff 190002

llvm/trunk/runtimes/llvm-strip-link.in

Show All 13 Lines if buf != ELF_MAGIC:
sys.exit(0) sys.exit(0)
llvm_objcopy = os.path.join('@LLVM_RUNTIME_OUTPUT_INTDIR@', 'llvm-objcopy') llvm_objcopy = os.path.join('@LLVM_RUNTIME_OUTPUT_INTDIR@', 'llvm-objcopy')
install_dir = os.path.join(os.getenv('DESTDIR', ''), '@CMAKE_INSTALL_PREFIX@') install_dir = os.path.join(os.getenv('DESTDIR', ''), '@CMAKE_INSTALL_PREFIX@')
link_dir = os.path.join(install_dir, 'lib', 'debug', '.build-id') link_dir = os.path.join(install_dir, 'lib', 'debug', '.build-id')
sys.exit(subprocess.call([ sys.exit(subprocess.call([
llvm_objcopy, llvm_objcopy,
'--strip-sections', '--strip-all',
'--build-id-link-dir=' + link_dir, '--build-id-link-dir=' + link_dir,
'--build-id-link-input=.debug', '--build-id-link-input=.debug',
'--build-id-link-output=', '--build-id-link-output=',
sys.argv[1], sys.argv[1],
])) ]))