Page MenuHomePhabricator

AMDHSA: Code object v3 updates
ClosedPublic

Authored by kzhuravl on Mar 6 2019, 3:07 PM.

Details

Summary
  • Copy kernel symbol attributes into kernel descriptor attributes
  • Make sure kernel symbol's visibility is not "higher" than protected

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl created this revision.Mar 6 2019, 3:07 PM
t-tye requested changes to this revision.Mar 7 2019, 12:33 AM
t-tye added inline comments.
lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
572 ↗(On Diff #189601)

Would it be worth giving the reason? It is to allow static relocations from the kernel descriptor to be used. Since the debugger is using the symtab I wonder if we can use hidden visibility. This symbol does not need to be in the dynsymtab.

This revision now requires changes to proceed.Mar 7 2019, 12:33 AM
kzhuravl updated this revision to Diff 189737.Mar 7 2019, 9:47 AM
kzhuravl marked an inline comment as done.

Address review feedback.

t-tye accepted this revision.Mar 7 2019, 11:22 AM

LGTM with comment update.

This revision is now accepted and ready to land.Mar 7 2019, 11:22 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2019, 11:59 AM