Repair the build when LLDB_DISABLE_PYTHON is set

[xiaobai]

Summary

If LLDB_DISABLE_PYTHON is set, some functions are unavailable but
SBReproducer assumes they are. Let's conditionally register those functions
since they are conditionally declared.

[JDevlieghere]

source/API/SBReproducer.cpp

821

The order of the methods doesn't matter within a block, feel free to group multiple of these functions together into one ifndef.

[xiaobai]

Group function registrations to cut down on ifdefs

[JDevlieghere]

LGTM, Thank you for fixing this!

source/API/SBReproducer.cpp

Register<bool(char *, size_t)>(static_cast<bool (*)(char *, size_t)>(
     LLDB_REGISTER_METHOD(bool, SBDebugger, DeleteCategory, (const char *));
     LLDB_REGISTER_METHOD(uint32_t, SBDebugger, GetNumCategories, ());
     LLDB_REGISTER_METHOD(lldb::SBTypeCategory, SBDebugger, GetCategoryAtIndex,
                          (uint32_t));
     LLDB_REGISTER_METHOD(lldb::SBTypeCategory, SBDebugger, GetDefaultCategory,
                          ());
     LLDB_REGISTER_METHOD(lldb::SBTypeFormat, SBDebugger, GetFormatForType,
                          (lldb::SBTypeNameSpecifier));
+#ifndef LLDB_DISABLE_PYTHON
     LLDB_REGISTER_METHOD(lldb::SBTypeSummary, SBDebugger, GetSummaryForType,
                          (lldb::SBTypeNameSpecifier));
-    LLDB_REGISTER_METHOD(lldb::SBTypeFilter, SBDebugger, GetFilterForType,
-                         (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(lldb::SBTypeSynthetic, SBDebugger, GetSyntheticForType,
                          (lldb::SBTypeNameSpecifier));
+#endif
+    LLDB_REGISTER_METHOD(lldb::SBTypeFilter, SBDebugger, GetFilterForType,
+                         (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(bool, SBDebugger, EnableLog,
                          (const char *, const char **));
   }
   {
     LLDB_REGISTER_CONSTRUCTOR(SBDeclaration, ());
     LLDB_REGISTER_CONSTRUCTOR(SBDeclaration, (const lldb::SBDeclaration &));
     LLDB_REGISTER_METHOD(
         const lldb::SBDeclaration &,

     LLDB_REGISTER_METHOD(lldb::LanguageType, SBTypeCategory, GetLanguageAtIndex,
                          (uint32_t));
     LLDB_REGISTER_METHOD(uint32_t, SBTypeCategory, GetNumLanguages, ());
     LLDB_REGISTER_METHOD(void, SBTypeCategory, AddLanguage,
                          (lldb::LanguageType));
     LLDB_REGISTER_METHOD(uint32_t, SBTypeCategory, GetNumFormats, ());
     LLDB_REGISTER_METHOD(uint32_t, SBTypeCategory, GetNumSummaries, ());
     LLDB_REGISTER_METHOD(uint32_t, SBTypeCategory, GetNumFilters, ());
+#ifndef LLDB_DISABLE_PYTHON
     LLDB_REGISTER_METHOD(uint32_t, SBTypeCategory, GetNumSynthetics, ());
     LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
-                         GetTypeNameSpecifierForFilterAtIndex, (uint32_t));
-    LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
-                         GetTypeNameSpecifierForFormatAtIndex, (uint32_t));
-    LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
-                         GetTypeNameSpecifierForSummaryAtIndex, (uint32_t));
-    LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
                          GetTypeNameSpecifierForSyntheticAtIndex, (uint32_t));
-    LLDB_REGISTER_METHOD(lldb::SBTypeFilter, SBTypeCategory, GetFilterForType,
-                         (lldb::SBTypeNameSpecifier));
-    LLDB_REGISTER_METHOD(lldb::SBTypeFormat, SBTypeCategory, GetFormatForType,
-                         (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(lldb::SBTypeSummary, SBTypeCategory, GetSummaryForType,
                          (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(lldb::SBTypeSynthetic, SBTypeCategory,
                          GetSyntheticForType, (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(lldb::SBTypeFilter, SBTypeCategory, GetFilterAtIndex,
                          (uint32_t));
-    LLDB_REGISTER_METHOD(lldb::SBTypeFormat, SBTypeCategory, GetFormatAtIndex,
-                         (uint32_t));
     LLDB_REGISTER_METHOD(lldb::SBTypeSummary, SBTypeCategory, GetSummaryAtIndex,
                          (uint32_t));
     LLDB_REGISTER_METHOD(lldb::SBTypeSynthetic, SBTypeCategory,
                          GetSyntheticAtIndex, (uint32_t));
+    LLDB_REGISTER_METHOD(bool, SBTypeCategory, AddTypeSummary,
+                         (lldb::SBTypeNameSpecifier, lldb::SBTypeSummary));
+    LLDB_REGISTER_METHOD(bool, SBTypeCategory, AddTypeSynthetic,
+                         (lldb::SBTypeNameSpecifier, lldb::SBTypeSynthetic));
+    LLDB_REGISTER_METHOD(bool, SBTypeCategory, DeleteTypeSynthetic,
+                         (lldb::SBTypeNameSpecifier));
+#endif
+    LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
+                         GetTypeNameSpecifierForFilterAtIndex, (uint32_t));
+    LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
+                         GetTypeNameSpecifierForFormatAtIndex, (uint32_t));
+    LLDB_REGISTER_METHOD(lldb::SBTypeNameSpecifier, SBTypeCategory,
+                         GetTypeNameSpecifierForSummaryAtIndex, (uint32_t));
+    LLDB_REGISTER_METHOD(lldb::SBTypeFilter, SBTypeCategory, GetFilterForType,
+                         (lldb::SBTypeNameSpecifier));
+    LLDB_REGISTER_METHOD(lldb::SBTypeFormat, SBTypeCategory, GetFormatForType,
+                         (lldb::SBTypeNameSpecifier));
+    LLDB_REGISTER_METHOD(lldb::SBTypeFormat, SBTypeCategory, GetFormatAtIndex,
+                         (uint32_t));
     LLDB_REGISTER_METHOD(bool, SBTypeCategory, AddTypeFormat,
                          (lldb::SBTypeNameSpecifier, lldb::SBTypeFormat));
     LLDB_REGISTER_METHOD(bool, SBTypeCategory, DeleteTypeFormat,
                          (lldb::SBTypeNameSpecifier));
-    LLDB_REGISTER_METHOD(bool, SBTypeCategory, AddTypeSummary,
-                         (lldb::SBTypeNameSpecifier, lldb::SBTypeSummary));
     LLDB_REGISTER_METHOD(bool, SBTypeCategory, DeleteTypeSummary,
                          (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(bool, SBTypeCategory, AddTypeFilter,
                          (lldb::SBTypeNameSpecifier, lldb::SBTypeFilter));
     LLDB_REGISTER_METHOD(bool, SBTypeCategory, DeleteTypeFilter,
                          (lldb::SBTypeNameSpecifier));
-    LLDB_REGISTER_METHOD(bool, SBTypeCategory, AddTypeSynthetic,
-                         (lldb::SBTypeNameSpecifier, lldb::SBTypeSynthetic));
-    LLDB_REGISTER_METHOD(bool, SBTypeCategory, DeleteTypeSynthetic,
-                         (lldb::SBTypeNameSpecifier));
     LLDB_REGISTER_METHOD(bool, SBTypeCategory, GetDescription,
                          (lldb::SBStream &, lldb::DescriptionLevel));
     LLDB_REGISTER_METHOD(
         lldb::SBTypeCategory &,
         SBTypeCategory, operator=,(const lldb::SBTypeCategory &));
     LLDB_REGISTER_METHOD(bool,
                          SBTypeCategory, operator==,(lldb::SBTypeCategory &));
     LLDB_REGISTER_METHOD(bool,
LLDB_REGISTER_METHOD(
         SBTypeSummary, operator=,(const lldb::SBTypeSummary &));
     LLDB_REGISTER_METHOD(bool,
                          SBTypeSummary, operator==,(lldb::SBTypeSummary &));
     LLDB_REGISTER_METHOD(bool, SBTypeSummary, IsEqualTo,
                          (lldb::SBTypeSummary &));
     LLDB_REGISTER_METHOD(bool,
                          SBTypeSummary, operator!=,(lldb::SBTypeSummary &));
   }
+#ifndef LLDB_DISABLE_PYTHON
   {
     LLDB_REGISTER_CONSTRUCTOR(SBTypeSynthetic, ());
     LLDB_REGISTER_STATIC_METHOD(lldb::SBTypeSynthetic, SBTypeSynthetic,
                                 CreateWithClassName, (const char *, uint32_t));
     LLDB_REGISTER_STATIC_METHOD(lldb::SBTypeSynthetic, SBTypeSynthetic,
                                 CreateWithScriptCode, (const char *, uint32_t));
     LLDB_REGISTER_CONSTRUCTOR(SBTypeSynthetic, (const lldb::SBTypeSynthetic &));
     LLDB_REGISTER_METHOD_CONST(bool, SBTypeSynthetic, IsValid, ());
LLDB_REGISTER_METHOD(
         SBTypeSynthetic, operator=,(const lldb::SBTypeSynthetic &));
     LLDB_REGISTER_METHOD(bool,
                          SBTypeSynthetic, operator==,(lldb::SBTypeSynthetic &));
     LLDB_REGISTER_METHOD(bool, SBTypeSynthetic, IsEqualTo,
                          (lldb::SBTypeSynthetic &));
     LLDB_REGISTER_METHOD(bool,
                          SBTypeSynthetic, operator!=,(lldb::SBTypeSynthetic &));
   }
+#endif
   {
     LLDB_REGISTER_CONSTRUCTOR(SBUnixSignals, ());
     LLDB_REGISTER_CONSTRUCTOR(SBUnixSignals, (const lldb::SBUnixSignals &));
     LLDB_REGISTER_METHOD(
         const lldb::SBUnixSignals &,
         SBUnixSignals, operator=,(const lldb::SBUnixSignals &));
     LLDB_REGISTER_METHOD(void, SBUnixSignals, Clear, ());
     LLDB_REGISTER_METHOD_CONST(bool, SBUnixSignals, IsValid, ());
LLDB_REGISTER_METHOD(const char *, SBValue, GetSummary,
                          (lldb::SBStream &, lldb::SBTypeSummaryOptions &));
     LLDB_REGISTER_METHOD(const char *, SBValue, GetLocation, ());
     LLDB_REGISTER_METHOD(bool, SBValue, SetValueFromCString, (const char *));
     LLDB_REGISTER_METHOD(bool, SBValue, SetValueFromCString,
                          (const char *, lldb::SBError &));
     LLDB_REGISTER_METHOD(lldb::SBTypeFormat, SBValue, GetTypeFormat, ());
     LLDB_REGISTER_METHOD(lldb::SBTypeSummary, SBValue, GetTypeSummary, ());
     LLDB_REGISTER_METHOD(lldb::SBTypeFilter, SBValue, GetTypeFilter, ());
+#ifndef LLDB_DISABLE_PYTHON
     LLDB_REGISTER_METHOD(lldb::SBTypeSynthetic, SBValue, GetTypeSynthetic, ());
+#endif
     LLDB_REGISTER_METHOD(lldb::SBValue, SBValue, CreateChildAtOffset,
                          (const char *, uint32_t, lldb::SBType));
     LLDB_REGISTER_METHOD(lldb::SBValue, SBValue, Cast, (lldb::SBType));
     LLDB_REGISTER_METHOD(lldb::SBValue, SBValue, CreateValueFromExpression,
                          (const char *, const char *));
     LLDB_REGISTER_METHOD(
         lldb::SBValue, SBValue, CreateValueFromExpression,
         (const char *, const char *, lldb::SBExpressionOptions &));