[DebugInfo][ExecutionEngine] follow up for "add SectionedAddress to DebugInfo interfaces"

[avl]

Summary

[ExecutionEngine] The https://reviews.llvm.org/D58194 patch changed symbolizer interface.
Particularily it requires not only Address but SectionIndex also. This patch set proper SectionIndex
instead of Undefined value. That cures several lit tests for ExecutionEngine.

[Hahnfeld]

llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp

153

According to the documentation, SymbolRef::getSection returns a section_iterator. Do we need to check against section_end()? (end_sections in the documentation is wrong!)

[avl]

llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp

153

Good catch! thanks. though there are many usages of this without checking for section_end().

[avl]

added check for section_end()

[avl]

ping.

[Hahnfeld]

I think the change is correct, but I don't know enough of the code to feel confident.

[avl]

abandon revision because of already integrated duplicated revision https://reviews.llvm.org/D59490

llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp

for (const std::pair<SymbolRef, uint64_t> &P : computeSymbolSizes(*DebugObj)) {
     uint64_t Size = P.second;
 
     // Record this address in a local vector
     Functions.push_back((void*)Addr);
 
     // Build the function loaded notification message
     iJIT_Method_Load FunctionMessage =
       FunctionDescToIntelJITFormat(*Wrapper, Name->data(), Addr, Size);
-    // TODO: it is neccessary to set proper SectionIndex here.
-    // object::SectionedAddress::UndefSection works for only absolute addresses.
-    DILineInfoTable Lines = Context->getLineInfoForAddressRange({Addr, object::SectionedAddress::UndefSection}, Size);
+
+    uint64_t SectionIndex = object::SectionedAddress::UndefSection;
+    if (auto SectOrErr = Sym.getSection())
+      if (*SectOrErr != Obj.section_end())
+        SectionIndex = SectOrErr.get()->getIndex();
+
+    DILineInfoTable Lines =
+        Context->getLineInfoForAddressRange({Addr, SectionIndex}, Size);
     DILineInfoTable::iterator Begin = Lines.begin();
     DILineInfoTable::iterator End = Lines.end();
     for (DILineInfoTable::iterator It = Begin; It != End; ++It) {
       LineInfo.push_back(
           DILineInfoToIntelJITFormat((uintptr_t)Addr, It->first, It->second));
     }
     if (LineInfo.size() == 0) {
       FunctionMessage.source_file_name = 0;