Page MenuHomePhabricator

[analyzer] MIGChecker: Enable by default.
ClosedPublic

Authored by NoQ on Feb 21 2019, 3:45 PM.

Details

Reviewers
dcoughlin
Summary

The checker has already proven to be fairly useful and wanted and doesn't have any known false positives, mostly because its positives are usually fairly local and there's no room for running into infeasible paths.

Diff Detail

Event Timeline

NoQ created this revision.Feb 21 2019, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2019, 3:45 PM
NoQ added a comment.Feb 21 2019, 3:46 PM

The TODOs for future polishing are:

  • Add a second trackExpressionValue() visitor to track argument values as they're copied around.
  • Introduce annotations for deallocator functions so that we no longer had to hardcode them and users could annotate their consuming functions.
This revision is now accepted and ready to land.Feb 21 2019, 3:49 PM
NoQ closed this revision.Feb 21 2019, 4:20 PM

Committed as rC354644 but i forgot to update the link as usual.