[analyzer] MIGChecker: Enable by default.

[NoQ]

Summary

The checker has already proven to be fairly useful and wanted and doesn't have any known false positives, mostly because its positives are usually fairly local and there's no room for running into infeasible paths.

[NoQ]

The TODOs for future polishing are:

• Add a second trackExpressionValue() visitor to track argument values as they're copied around.
• Introduce annotations for deallocator functions so that we no longer had to hardcode them and users could annotate their consuming functions.

[dcoughlin]

LGTM.

[NoQ]

Committed as rC354644 but i forgot to update the link as usual.

clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

 def MacOSXAPIChecker : Checker<"API">,
   HelpText<"Check for proper uses of various Apple APIs">,
   Documentation<HasDocumentation>;
 
 def MacOSKeychainAPIChecker : Checker<"SecKeychainAPI">,
   HelpText<"Check for proper uses of Secure Keychain APIs">,
   Documentation<HasDocumentation>;
 
+def MIGChecker : Checker<"MIG">,
+  HelpText<"Find violations of the Mach Interface Generator "
+           "calling convention">,
+  Documentation<NotDocumented>;
+
 def ObjCPropertyChecker : Checker<"ObjCProperty">,
   HelpText<"Check for proper uses of Objective-C properties">,
   Documentation<NotDocumented>;
 
 def OSObjectRetainCountChecker : Checker<"OSObjectRetainCount">,
   HelpText<"Check for leaks and improper reference count management for "
            "OSObject">,
   Dependencies<[RetainCountBase]>,

 let ParentPackage = Performance in {
 
 def GCDAntipattern : Checker<"GCDAntipattern">,
   HelpText<"Check for performance anti-patterns when using Grand Central "
            "Dispatch">,
   Documentation<NotDocumented>;
 } // end "optin.performance"
 
-let ParentPackage = OSXAlpha in {
-
-def MIGChecker : Checker<"MIG">,
-  HelpText<"Find violations of the Mach Interface Generator "
-           "calling convention">,
-  Documentation<NotDocumented>;
-
-} // end "alpha.osx"
-
 let ParentPackage = CocoaAlpha in {
 
 def IvarInvalidationModeling : Checker<"IvarInvalidationModeling">,
   HelpText<"Gathers information for annotation driven invalidation checking "
            "for classes that contains a method annotated with "
            "'objc_instance_variable_invalidator'">,
   Documentation<NotDocumented>;
 

clang/test/Analysis/mig.mm

-// RUN: %clang_analyze_cc1 -w -analyzer-checker=core,alpha.osx.MIG\
+// RUN: %clang_analyze_cc1 -w -analyzer-checker=core,osx.MIG\
 // RUN:                       -analyzer-output=text -fblocks -verify %s
 
 typedef unsigned uint32_t;
 
 // XNU APIs.
 
 typedef int kern_return_t;
 #define KERN_SUCCESS 0