AddressSanitizer: fix for SPARC with GCC

[ebotcazou]

Summary

This patch contains a fixlet for the AddressSanitizer on the SPARC with GCC, which would otherwise generate a problematic call to the intercepted memcpy routine. It was tested with GCC on SPARC/Solaris and SPARC/Linux.

Patch by Eric Botcazou.

[vitalybuka]

compiler-rt/lib/asan/asan_globals.cc

115 ↗

(On Diff #187539)

Could you please upload patches with "arc" tool https://llvm.org/docs/Phabricator.html#subversion-and-arcanist-deprecated
Without it we have "Context not available."

118 ↗

(On Diff #187539)

sizeof(g)

119 ↗

(On Diff #187539)

clang-format

[ebotcazou]

Changed sizeof (Global) to sizeof (g) and removed extraneous space.

[ebotcazou]

compiler-rt/lib/asan/asan_globals.cc

115 ↗

(On Diff #187539)

No, sorry, I don't have arcanist handy.

118 ↗

(On Diff #187539)

Changed.

119 ↗

(On Diff #187539)

Fixed.

[ro]

compiler-rt/lib/asan/asan_globals.cc

119 ↗

(On Diff #187789)

It would be helpful the have the explanation from the summary
as a comment in the code so it becomes immediately obvious
what's going on.

[ebotcazou]

compiler-rt/lib/asan/asan_globals.cc

119 ↗

(On Diff #187789)

Other similar uses of internal_memcpy don't have a comment, but I can add one.

[ebotcazou]

Any objection to accepting this? We need it alongside D58431 to fix the Sanitizer failures in the GCC testsuite on the SPARC platforms and I'd rather not maintain it separately in the GCC tree.

lib/asan/asan_globals.cc

int GetGlobalsForAddress(uptr addr, Global *globals, u32 *reg_sites,
   if (!flags()->report_globals) return 0;
   BlockingMutexLock lock(&mu_for_globals);
   int res = 0;
   for (ListOfGlobals *l = list_of_all_globals; l; l = l->next) {
     const Global &g = *l->g;
     if (flags()->report_globals >= 2)
       ReportGlobal(g, "Search");
     if (IsAddressNearGlobal(addr, g)) {
+#if defined(__GNUC__) && defined(__sparc__)
+      internal_memcpy(&globals[res], &g, sizeof(g));
+#else
       globals[res] = g;
+#endif
       if (reg_sites)
         reg_sites[res] = FindRegistrationSite(&g);
       res++;
       if (res == max_globals) break;
     }
   }
   return res;
 }