This is an archive of the discontinued LLVM Phabricator instance.

Don't source local .lldbinit in the test suite
ClosedPublic

Authored by teemperor on Feb 14 2019, 6:50 AM.

Details

Summary

As suggested by Pavel, we shouldn't let our tests parse the local .lldbinit to prevent random test failures
due to changed settings.

Fixes Minidump/Windows/Sigsegv/sigsegv.test (and probably others too).

Diff Detail

Repository
rLLDB LLDB

Event Timeline

teemperor created this revision.Feb 14 2019, 6:50 AM
Herald added a project: Restricted Project. · View Herald Transcript

Are you sure you're adding this to the right place? This is modifying the substitution for lldb-mi and not lldb..

teemperor updated this revision to Diff 186850.Feb 14 2019, 8:33 AM

Ah yes, that also explains why the test suit failed. Fixed and the test now passes, thanks!

labath accepted this revision.Feb 14 2019, 8:50 AM

lgtm

This revision is now accepted and ready to land.Feb 14 2019, 8:50 AM
This revision was automatically updated to reflect the committed changes.