[lldb] [unittests] XFAIL two unittests failing on NetBSD

[mgorny]

Summary

The two following LLDBServerTests fail reliably on NetBSD:

StandardStartupTest.TestStopReplyContainsThreadPcs
TestBase.LaunchModePreservesEnvironment

Establish an XFAIL behavior to let buildbots test for regressions
while we are still working on fixing them.

[mgorny]

FTR, I've tried both @zturner's and @labath's XFAIL suggestions and the former doesn't work because we're not using exeptions, and the latter just gives some creepy C++ errors. Then I figured out this is probably the simplest and most readable possibility.

[mgorny]

@labath suggested another implementation possibility on IRC, I'll be trying it tomorrow.

[mgorny]

Bad news: so far the alternate implementation suggestions don't work.

Good news: we don't need after all. The EINTR fix seems to have fixed all the remaining tests for us.

lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp

 TEST_F(TestBase, LaunchModePreservesEnvironment) {
   putenv(const_cast<char *>("LLDB_TEST_MAGIC_VARIABLE=LLDB_TEST_MAGIC_VALUE"));
 
   auto ClientOr = TestClient::launch(getLogFileName(),
                                      {getInferiorPath("environment_check")});
   ASSERT_THAT_EXPECTED(ClientOr, Succeeded());
   auto &Client = **ClientOr;
 
+#if defined(__NetBSD__)
+  // XFAIL: this test currently fails on NetBSD
+  ASSERT_THAT_ERROR(Client.ContinueAll(), Failed());
+#else
   ASSERT_THAT_ERROR(Client.ContinueAll(), Succeeded());
   ASSERT_THAT_EXPECTED(
       Client.GetLatestStopReplyAs<StopReplyExit>(),
       HasValue(testing::Property(&StopReply::getKind,
                                  WaitStatus{WaitStatus::Exit, 0})));
+#endif
 }
 
 TEST_F(TestBase, DS_TEST(DebugserverEnv)) {
   // Test that --env takes precedence over inherited environment variables.
   putenv(const_cast<char *>("LLDB_TEST_MAGIC_VARIABLE=foobar"));
 
   auto ClientOr = TestClient::launchCustom(getLogFileName(),
       { "--env", "LLDB_TEST_MAGIC_VARIABLE=LLDB_TEST_MAGIC_VALUE" },

lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp

 
 TEST_F(StandardStartupTest, TestStopReplyContainsThreadPcs) {
   // This inferior spawns 4 threads, then forces a break.
   ASSERT_THAT_ERROR(
       Client->SetInferior({getInferiorPath("thread_inferior"), "4"}),
       Succeeded());
 
   ASSERT_THAT_ERROR(Client->ListThreadsInStopReply(), Succeeded());
+#if defined(__NetBSD__)
+  // XFAIL: this test currently fails on NetBSD
+  ASSERT_THAT_ERROR(Client->ContinueAll(), Failed());
+#else
   ASSERT_THAT_ERROR(Client->ContinueAll(), Succeeded());
   unsigned int pc_reg = Client->GetPcRegisterId();
   ASSERT_NE(pc_reg, UINT_MAX);
 
   auto jthreads_info = Client->GetJThreadsInfo();
   ASSERT_THAT_EXPECTED(jthreads_info, Succeeded());
 
   auto stop_reply = Client->GetLatestStopReplyAs<StopReplyStop>();
   ASSERT_THAT_EXPECTED(stop_reply, Succeeded());
   auto stop_reply_pcs = stop_reply->getThreadPcs();
   auto thread_infos = jthreads_info->GetThreadInfos();
   ASSERT_EQ(stop_reply_pcs.size(), thread_infos.size())
       << "Thread count mismatch.";
 
   for (auto stop_reply_pc : stop_reply_pcs) {
     unsigned long tid = stop_reply_pc.first;
     ASSERT_TRUE(thread_infos.find(tid) != thread_infos.end())
         << "Thread ID: " << tid << " not in JThreadsInfo.";
     EXPECT_THAT(thread_infos[tid].ReadRegister(pc_reg),
                 Pointee(Eq(stop_reply_pc.second)));
   }
+#endif
 }