Page MenuHomePhabricator

[libcxx] Preserve order, avoid duplicates when merging static archives
ClosedPublic

Authored by phosek on Feb 10 2019, 9:33 PM.

Details

Summary

glob can return files in arbitrary order which breaks deterministic
builds. Rather, use ar t to list the files in each archive and
preserve the original order. Using ar q results in duplicate entries
in the archive, instead use ar r to avoid duplicates.

Diff Detail

Repository
rCXX libc++

Event Timeline

phosek created this revision.Feb 10 2019, 9:33 PM
EricWF accepted this revision.Feb 10 2019, 10:35 PM
This revision is now accepted and ready to land.Feb 10 2019, 10:35 PM
This revision was automatically updated to reflect the committed changes.