Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
comments
llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp | ||
---|---|---|
99 | Done, but not sure if the error printing code is how it's supposed to look; feels a bit roundabout. |
Comment Actions
LGTM
I think this is generally how the error handlers are supposed to look, see e.g. the other callers of handleAllErrors.
Could you make this take an llvm::Error and change the caller with the error_code to use errorCodeToError? We're (slowly) trying to eradicate std::error_code and errorToErrorCode from the codebase.