This is an archive of the discontinued LLVM Phabricator instance.

Differential D57808

[LLD] [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option
ClosedPublic

Authored by mstorsjo on Feb 6 2019, 12:20 AM.

Details

Reviewers
ruiu
rnk
Commits
rGdfb2fcd224fd: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option
rL353342: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option
rLLD353342: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 6 2019, 12:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 12:20 AM
ruiu accepted this revision.Feb 6 2019, 9:28 AM

LGTM

This revision is now accepted and ready to land.Feb 6 2019, 9:28 AM
Closed by commit rLLD353342: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option (authored by mstorsjo). · Explain WhyFeb 6 2019, 1:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MinGW/
2 lines
2 lines
test/
MinGW/
3 lines

Diff 185495

MinGW/Driver.cpp

Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines if (Args.hasArg(OPT_large_address_aware))
Add("-largeaddressaware"); Add("-largeaddressaware");
if (Args.hasArg(OPT_kill_at)) if (Args.hasArg(OPT_kill_at))
Add("-kill-at"); Add("-kill-at");
if (Args.getLastArgValue(OPT_m) != "thumb2pe" && if (Args.getLastArgValue(OPT_m) != "thumb2pe" &&
Args.getLastArgValue(OPT_m) != "arm64pe" && !Args.hasArg(OPT_dynamicbase)) Args.getLastArgValue(OPT_m) != "arm64pe" && !Args.hasArg(OPT_dynamicbase))
Add("-dynamicbase:no"); Add("-dynamicbase:no");
if (Args.hasArg(OPT_no_insert_timestamp)) if (Args.hasFlag(OPT_no_insert_timestamp, OPT_insert_timestamp, false))
Add("-timestamp:0"); Add("-timestamp:0");
if (Args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false)) if (Args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false))
Add("-opt:ref"); Add("-opt:ref");
else else
Add("-opt:noref"); Add("-opt:noref");
if (auto *A = Args.getLastArg(OPT_icf)) { if (auto *A = Args.getLastArg(OPT_icf)) {
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines

MinGW/Options.td

Show All 10 Lines
def dynamicbase: F<"dynamicbase">, HelpText<"Enable ASLR">; def dynamicbase: F<"dynamicbase">, HelpText<"Enable ASLR">;
def entry: S<"entry">, MetaVarName<"<entry>">, def entry: S<"entry">, MetaVarName<"<entry>">,
HelpText<"Name of entry point symbol">; HelpText<"Name of entry point symbol">;
def export_all_symbols: F<"export-all-symbols">, def export_all_symbols: F<"export-all-symbols">,
HelpText<"Export all symbols even if a def file or dllexport attributes are used">; HelpText<"Export all symbols even if a def file or dllexport attributes are used">;
def gc_sections: F<"gc-sections">, HelpText<"Remove unused sections">; def gc_sections: F<"gc-sections">, HelpText<"Remove unused sections">;
def icf: J<"icf=">, HelpText<"Identical code folding">; def icf: J<"icf=">, HelpText<"Identical code folding">;
def image_base: S<"image-base">, HelpText<"Base address of the program">; def image_base: S<"image-base">, HelpText<"Base address of the program">;
def insert_timestamp: F<"insert-timestamp">,
HelpText<"Include PE header timestamp">;
def kill_at: F<"kill-at">, HelpText<"Remove @n from exported symbols">; def kill_at: F<"kill-at">, HelpText<"Remove @n from exported symbols">;
def l: JoinedOrSeparate<["-"], "l">, MetaVarName<"<libName>">, def l: JoinedOrSeparate<["-"], "l">, MetaVarName<"<libName>">,
HelpText<"Root name of library to use">; HelpText<"Root name of library to use">;
def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">; def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">;
def map: S<"Map">, HelpText<"Output a linker map">; def map: S<"Map">, HelpText<"Output a linker map">;
def map_eq: J<"Map=">, Alias<map>; def map_eq: J<"Map=">, Alias<map>;
def no_insert_timestamp: F<"no-insert-timestamp">, def no_insert_timestamp: F<"no-insert-timestamp">,
HelpText<"Don't include PE header timestamp">; HelpText<"Don't include PE header timestamp">;
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines

test/MinGW/driver.test

Show First 20 Lines • Show All 147 Lines • ▼ Show 20 Lines
RUN: ld.lld -### foo.o -m i386pe -require-defined _foo --require-defined _bar -require-defined=_baz --require-defined=_foo2 | FileCheck -check-prefix=REQUIRE-DEFINED %s RUN: ld.lld -### foo.o -m i386pe -require-defined _foo --require-defined _bar -require-defined=_baz --require-defined=_foo2 | FileCheck -check-prefix=REQUIRE-DEFINED %s
REQUIRE-DEFINED: -include:_foo -include:_bar -include:_baz -include:_foo2 REQUIRE-DEFINED: -include:_foo -include:_bar -include:_baz -include:_foo2
RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix LIBPATH %s RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix LIBPATH %s
LIBPATH: -libpath:libpath LIBPATH: -libpath:libpath
RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s
RUN: ld.lld -### -m i386pep foo.o --insert-timestamp --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s
NOTIMESTAMP: -timestamp:0 NOTIMESTAMP: -timestamp:0
RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp --insert-timestamp | FileCheck -check-prefix TIMESTAMP %s
TIMESTAMP-NOT: -timestamp:0