Page MenuHomePhabricator

[analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls
ClosedPublic

Authored by george.karpenkov on Feb 5 2019, 1:47 PM.

Diff Detail

Repository
rC Clang

Event Timeline

NoQ accepted this revision.Feb 5 2019, 1:51 PM
NoQ added inline comments.
clang/lib/Analysis/RetainSummaryManager.cpp
503 ↗(On Diff #185392)

So if an OSObject-related method deals with NS or CF objects, we wouldn't escape it anymore?

I thing there might exist such code somewhere in between kernel and userland.

clang/test/Analysis/retain-release.mm
489 ↗(On Diff #185392)

I enjoy namespacing my generic names, this way i can use generic names without being afraid to collide with someone else's code (cf. the test above).

This revision is now accepted and ready to land.Feb 5 2019, 1:51 PM
This revision was automatically updated to reflect the committed changes.
george.karpenkov marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 2:26 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript