Page MenuHomePhabricator

[MC] Don't error on numberless .file directives on MachO
ClosedPublic

Authored by rnk on Feb 5 2019, 11:24 AM.

Details

Summary

Before r349976, MC ignored such directives when producing an object file
and asserted when re-producing textual assembly output. I turned this
assertion into a hard error in both cases in r349976, but this makes it
unnecessarily difficult to write a single assembly file that supports
both MachO and other object formats that support .file. A user reported
this as PR40578, and we decided to go back to ignoring the directive.

Fixes PR40578

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Feb 5 2019, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 11:24 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
This revision is now accepted and ready to land.Feb 5 2019, 11:39 AM
This revision was automatically updated to reflect the committed changes.