This is an archive of the discontinued LLVM Phabricator instance.

[mips] Add names and tests for the hardware registers
ClosedPublic

Authored by vkalintiris on Oct 13 2014, 4:18 PM.

Diff Detail

Event Timeline

vkalintiris retitled this revision from to [mips] Add names and tests for the hardware registers.
vkalintiris updated this object.
vkalintiris edited the test plan for this revision. (Show Details)
vkalintiris added a reviewer: dsanders.
vkalintiris added a subscriber: Unknown Object (MLST).
dsanders accepted this revision.Nov 4 2014, 2:47 AM
dsanders edited edge metadata.

LGTM with a nit, hwr_ulr added, and the FIXME comments about the .set directives.

lib/Target/Mips/AsmParser/MipsAsmParser.cpp
1760

Could you add 'hwr_ulr' ($29) too? GAS doesn't accept it at the moment, but it's in the spec.

2255

Nit: Multiple blank lines

test/MC/Mips/mips-hwr-register-names.s
6–9

Could you add a FIXME comment about the .set lines?

Eventually, I'd like the instruction printer for rdhwr to stop printing the .set directives around it (this doesn't need to be done in this patch). It makes some sense for CodeGen to do emit them but not for the assembler.

test/MC/Mips/mips32r2/valid.s
140–143

I'd like to remove the checks for the .set directives but the encoding is on the '.set pop' line so we'd have to keep that for the moment. It would look strange to have a .set pop without a .set push so let's leave the .set directives in the test for now.

Could you add a FIXME comment about them?

This revision is now accepted and ready to land.Nov 4 2014, 2:47 AM
vkalintiris closed this revision.Nov 4 2014, 1:41 PM
vkalintiris updated this revision to Diff 15786.

Closed by commit rL221299 (authored by @vkalintiris).