This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add codegen support for the import_field attribute
ClosedPublic

Authored by sunfish on Feb 1 2019, 10:38 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sunfish created this revision.Feb 1 2019, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 10:38 AM
sbc100 accepted this revision.Feb 1 2019, 11:44 AM

LGTM % comments

include/llvm/MC/MCSymbolWasm.h
36

Should we make these both Optional to save some space? Since in the vast majority of cases they will not be set?

It might be nice to be able to distinguish between MCSymbol with custom module names/fields and those without.

This revision is now accepted and ready to land.Feb 1 2019, 11:44 AM
This revision was automatically updated to reflect the committed changes.