Fix https://bugs.llvm.org/show_bug.cgi?id=38583: Describe how memcpy/memmove/memset behave when len=0. Also fix some fallout from when the alignment parameter was replaced by an attribute.
Please make sure you have llvm-commits added as a subscriber when creating patches in the future (I'm not sure why Herald sometimes doesn't do it). The patch that changed this was rL322965, and I fixed one of the related regressions, and was meaning to update the docs but never did, so LGTM and I'm happy signing off on this.
Please make sure you have llvm-commits added as a subscriber when creating patches in the future
Thanks, I'll try to remember. It might be worth clarifying at https://llvm.org/docs/Phabricator.html#phabricator-request-review-web that "adding a reviewer" and "subscribing someone" is *not* the same thing. As someone who has not used Phabricator ever before, I figured these would just be different terms for the same thing; I had no idea there are separate lists of "reviewers" and "subscribers" (llvm-commits is, after all, mentioned in the bullet point that is all about adding reviewers).
was meaning to update the docs but never did
Notice that this does not just fix the fallout from that patch. The remarks about what happens when "len" is 0 are new, and based on the feedback I received at https://bugs.llvm.org/show_bug.cgi?id=38583.
I also just found a typo in my patch, so now I will have to figure out how to update a patch here.