[SCEV] Do not bother creating separate SCEVUnknown for unreachable nodes

[mkazantsev]

Summary

Currently, SCEV creates SCEVUnknown for every node of unreachable code. If we
have a huge amounts of such code, we will be littering SE with these nodes. We could
just state that they all are undef and save some memory.

[sanjoy]

This is fine, but IMO mapping them to undef feels cleaner conceptually.

[mkazantsev]

Makes sense, undef works fine, too.

[mkazantsev]

Remade to undef.

lib/Analysis/ScalarEvolution.cpp

if (!isSCEVable(V->getType()))
     return getUnknown(V);
 
   if (Instruction *I = dyn_cast<Instruction>(V)) {
     // Don't attempt to analyze instructions in blocks that aren't
     // reachable. Such instructions don't matter, and they aren't required
     // to obey basic rules for definitions dominating uses which this
     // analysis depends on.
     if (!DT.isReachableFromEntry(I->getParent()))
-      return getUnknown(V);
+      return getZero(V->getType());
   } else if (ConstantInt *CI = dyn_cast<ConstantInt>(V))
     return getConstant(CI);
   else if (isa<ConstantPointerNull>(V))
     return getZero(V->getType());
   else if (GlobalAlias *GA = dyn_cast<GlobalAlias>(V))
     return GA->isInterposable() ? getUnknown(V) : getSCEV(GA->getAliasee());
   else if (!isa<ConstantExpr>(V))
     return getUnknown(V);

test/Analysis/ScalarEvolution/unreachable-code.ll

 ; RUN: opt < %s -analyze -scalar-evolution | FileCheck %s
 
 ; CHECK: %t = add i64 %t, 1
-; CHECK: -->  %t
+; CHECK: -->  0
 
 define void @foo() {
 entry:
   ret void
 
 dead:
   %t = add i64 %t, 1
   ret void
 }