Page MenuHomePhabricator

[llvm-nm] Report '.comment' ELF sections as 'n' instead of '?'
ClosedPublic

Authored by mattd on Jan 31 2019, 2:34 PM.

Details

Summary

The previous implementation reported .comment sections as '?'
GNU uses 'n' which means "The symbol is a debugging symbol." .note sections are represented as 'n' too.

Diff Detail

Event Timeline

mattd created this revision.Jan 31 2019, 2:34 PM
jhenderson accepted this revision.Feb 1 2019, 1:57 AM

LGTM. The CHECK-NEXT can be in a follow-on, or just during the commit, assuming there's no issues.

llvm/test/Object/nm-trivial-object.test
118–127

Could you use ELF64-DEBUG-SYMS-NEXT here to capture all the section names, and make sure there are no others we're missing?

This revision is now accepted and ready to land.Feb 1 2019, 1:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 9:37 AM