This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Add <experimental/type_traits> for LFTS

Authored by EricWF on Oct 11 2014, 11:16 AM.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 14771.Oct 11 2014, 11:16 AM
EricWF retitled this revision from to [libcxx] Add <experimental/type_traits> for LFTS.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: mclow.lists, K-ballo.
EricWF added a subscriber: Unknown Object (MLST).
K-ballo added inline comments.Oct 11 2014, 11:55 AM

Shouldn't this go right after is_convertible_v?


void is not a literal type in C++11, does that matter?

EricWF updated this revision to Diff 14772.Oct 11 2014, 12:22 PM

Fix some comments brought up by K-Ballo.

EricWF updated this revision to Diff 14774.Oct 11 2014, 11:27 PM

I moved the __has_feature(variable_templates) endif to before the invocation traits.

mclow.lists accepted this revision.Dec 16 2014, 6:58 PM
mclow.lists edited edge metadata.

LGTM - sorry for the long wait.

This revision is now accepted and ready to land.Dec 16 2014, 6:58 PM
EricWF closed this revision.Dec 19 2014, 2:22 PM