Page MenuHomePhabricator

K-ballo (Agustín Bergé)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2014, 4:52 PM (338 w, 3 d)

Recent Activity

Jan 14 2018

K-ballo abandoned D33776: [libcxx] LWG2221: No formatted output operator for nullptr.
Jan 14 2018, 1:45 PM
K-ballo abandoned D7060: Implement CWG496: Is a volatile-qualified type really a POD?.
Jan 14 2018, 1:45 PM
K-ballo abandoned D5942: [libcxx] Support UDTs convertible to arithmetic types in <cmath>.
Jan 14 2018, 1:44 PM

Dec 13 2017

K-ballo added inline comments to D33776: [libcxx] LWG2221: No formatted output operator for nullptr.
Dec 13 2017, 12:06 PM

Dec 12 2017

K-ballo added a comment to D38831: [libcxx] P0604, invoke_result and is_invocable.

Thanks @lichray

Dec 12 2017, 4:39 PM
K-ballo updated the diff for D38831: [libcxx] P0604, invoke_result and is_invocable.

Fixed incorrect test case.

Dec 12 2017, 6:52 AM
K-ballo added a comment to D38831: [libcxx] P0604, invoke_result and is_invocable.
[...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9: error: static_assert failed due to requirement '!std::is_nothrow_invocable_r_v<int, Fn>' ""
        static_assert(!std::is_nothrow_invocable_r_v<int, Fn>, "");
        ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
--

with Clang-5.0 and trunk. Can you reproduce?

Dec 12 2017, 5:04 AM
bebuch awarded D38831: [libcxx] P0604, invoke_result and is_invocable a Evil Spooky Haunted Tree token.
Dec 12 2017, 3:53 AM

Nov 24 2017

K-ballo updated the diff for D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.

Turn fail test into SFINAE based pass test, mark XFAIL for clang.

Nov 24 2017, 6:42 AM

Nov 22 2017

K-ballo updated the diff for D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.

Back to decltype-based SFINAE.

Nov 22 2017, 12:46 PM

Nov 21 2017

K-ballo updated the diff for D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.

Full context diff.

Nov 21 2017, 9:02 AM

Nov 20 2017

K-ballo updated the diff for D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.

Addressed review comments. Added tests for SFINAE, noexcept, deduction guide.

Nov 20 2017, 4:04 PM
K-ballo created D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 20 2017, 10:25 AM

Nov 6 2017

K-ballo added a comment to D38831: [libcxx] P0604, invoke_result and is_invocable.

@K-ballo I always forget. Do you have commit access?

Nov 6 2017, 7:52 PM

Oct 21 2017

K-ballo updated the diff for D38831: [libcxx] P0604, invoke_result and is_invocable.

Fix synopsis

Oct 21 2017, 10:02 AM

Oct 12 2017

K-ballo abandoned D5133: [libcxx] type_info support for MSVC.
Oct 12 2017, 4:12 PM
K-ballo abandoned D5131: [libcxx] unexpected/terminate support for MS CRT.
Oct 12 2017, 4:11 PM
K-ballo abandoned D5127: [libcxx] Initializer list support for MSVC.
Oct 12 2017, 4:11 PM
K-ballo abandoned D5126: [libcxx] Emulation of atomic builtins for MSVC.
Oct 12 2017, 4:11 PM

Oct 11 2017

K-ballo created D38831: [libcxx] P0604, invoke_result and is_invocable.
Oct 11 2017, 4:47 PM

Jun 1 2017

K-ballo created D33776: [libcxx] LWG2221: No formatted output operator for nullptr.
Jun 1 2017, 6:22 AM

Apr 12 2017

K-ballo accepted D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr..

LGTM

Apr 12 2017, 4:56 PM

Apr 4 2017

K-ballo added a comment to D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr..

I don't see any potential layout change, other than the case in which both T1 and T2 are empty (which I understand doesn't happen within libc++). As far as I know, the rest of the cases should result in the same layout regardless of whether EBO actually applies or not.

Apr 4 2017, 6:38 PM

Sep 15 2016

K-ballo added a comment to D24637: [libc++] Extension: Make `move` and `forward` constexpr in C++11..

I like this!

Sep 15 2016, 3:16 PM

Jun 13 2016

K-ballo added a comment to D21260: Implement variadic lock_guard..

LGTM

Jun 13 2016, 3:20 PM

Dec 15 2015

K-ballo updated the diff for D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&&.

Addressed review comments. Use UNSUPPORTED in pairs.by.type.pass.

Dec 15 2015, 12:32 PM

Dec 10 2015

K-ballo updated the diff for D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&&.

Addressed review comments

Dec 10 2015, 8:54 AM
K-ballo added a comment to D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&&.
int x = 42;
int const y = 43;
std::pair<int&, int const&> const p(x, y);
static_assert(std::is_same<int const&, decltype(std::get<0>(std::move(p)))>::value, "");
static_assert(std::is_same<int const&, decltype(std::get<1>(std::move(p)))>::value, "");

I assume you agree that this test has the correct behavior?

Dec 10 2015, 7:37 AM

Dec 9 2015

K-ballo added a comment to D14814: [libcxx] Use __make_integer_seq builtin when available.

After that these changes LGTM. @K-ballo I'm happy to make the changes as I commit this if your OK with that?

Dec 9 2015, 12:43 PM

Nov 19 2015

K-ballo retitled D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&& from to [libcxx] LWG2485: get() should be overloaded for const tuple&&.
Nov 19 2015, 12:56 PM
K-ballo retitled D14814: [libcxx] Use __make_integer_seq builtin when available from to [libcxx] Use __make_integer_seq builtin when available.
Nov 19 2015, 3:54 AM

Sep 7 2015

K-ballo added a comment to D6964: [libcxx] SFINAE-friendly common_type.

@K-ballo May I commit this with a couple of small changes? I want to fully qualify all of the calls to "declval<Tp>(...)".

Sep 7 2015, 5:00 PM

Jul 7 2015

K-ballo added a comment to D10997: [libcxx] LWG2420 bits for bind<void>.

Can I commit this for you?

Jul 7 2015, 7:18 PM
K-ballo added a comment to D10997: [libcxx] LWG2420 bits for bind<void>.

I don't think we need any changes in __functional_03 because we don't provide bind in 03 :)

Jul 7 2015, 3:48 PM
K-ballo retitled D10997: [libcxx] LWG2420 bits for bind<void> from to [libcxx] LWG2420 bits for bind<void>.
Jul 7 2015, 8:22 AM

Jun 23 2015

K-ballo added a comment to D5126: [libcxx] Emulation of atomic builtins for MSVC.

Waiting for VS2015RTM

Jun 23 2015, 8:25 AM
K-ballo added a comment to D5133: [libcxx] type_info support for MSVC.

Waiting for VS2015RTM

Jun 23 2015, 8:25 AM
K-ballo added a comment to D5127: [libcxx] Initializer list support for MSVC.

Waiting for VS2015RTM

Jun 23 2015, 8:25 AM
K-ballo added a comment to D5131: [libcxx] unexpected/terminate support for MS CRT.

Waiting for VS2015RTM

Jun 23 2015, 8:25 AM

Jun 12 2015

K-ballo added a comment to D10191: [libcxx] LWG2442: call_once() shouldn't DECAY_COPY().

@K-ballo Do you want me to commit this for you?

Jun 12 2015, 9:05 AM

Jun 8 2015

K-ballo updated the diff for D10191: [libcxx] LWG2442: call_once() shouldn't DECAY_COPY().

Addressed review comments:

Jun 8 2015, 3:28 PM

Jun 4 2015

K-ballo added inline comments to D10191: [libcxx] LWG2442: call_once() shouldn't DECAY_COPY().
Jun 4 2015, 12:41 PM

Jun 2 2015

K-ballo retitled D10191: [libcxx] LWG2442: call_once() shouldn't DECAY_COPY() from to [libcxx] LWG2442: call_once() shouldn't DECAY_COPY().
Jun 2 2015, 11:16 AM

May 1 2015

K-ballo added a comment to D6964: [libcxx] SFINAE-friendly common_type.

Just so I'm sure I understand: This implementation applies decay<T> for ever pair of types in common_type<T...> even though N2408 says decay is only applied to the final type?

May 1 2015, 11:17 AM

Feb 12 2015

K-ballo added inline comments to D7569: [libc++] Try and prevent evaluation of `is_default_constructible` on tuples default constructor if it is not needed..
Feb 12 2015, 4:39 PM

Feb 11 2015

K-ballo added inline comments to D6964: [libcxx] SFINAE-friendly common_type.
Feb 11 2015, 6:34 AM

Feb 9 2015

K-ballo added a comment to D7444: [libcxx] Fix PR 22468 - std::function<void()> does not accept non-void-returning functions .

After we found some corner cases where my simpler approach does the wrong thing, I think Eric's patch is the way to go.

Feb 9 2015, 3:34 PM

Feb 6 2015

K-ballo added a comment to D7444: [libcxx] Fix PR 22468 - std::function<void()> does not accept non-void-returning functions .

The current functionality is correct as LWG2420 has not yet been accepted (note I'm the submitter). I'm sitting on a patch to implement the currently intended resolution (apply change to INVOKE, not just function) in a considerably simpler way, waiting for that direction to be confirmed.

Feb 6 2015, 1:03 PM

Jan 28 2015

K-ballo closed D7111: [libcxx] Fix match_results for alternatives.

SVN r227384

Jan 28 2015, 2:45 PM

Jan 24 2015

K-ballo added inline comments to D7111: [libcxx] Fix match_results for alternatives.
Jan 24 2015, 4:40 PM

Jan 23 2015

K-ballo updated the diff for D7111: [libcxx] Fix match_results for alternatives.

Address review comments.

Jan 23 2015, 11:55 AM
K-ballo updated the diff for D7060: Implement CWG496: Is a volatile-qualified type really a POD?.

Addressed review comments. Added test for the newly introduced diagnostic.

Jan 23 2015, 11:16 AM
K-ballo added a comment to D7111: [libcxx] Fix match_results for alternatives.

The fix looks reasonable, it fixes the OP's problem, and the new test fails w/o the fix.

However, the change to <regex> is in two places, and I don't see how this test exercises both code paths.

Jan 23 2015, 10:52 AM

Jan 21 2015

K-ballo retitled D7111: [libcxx] Fix match_results for alternatives from to [libcxx] Fix match_results for alternatives.
Jan 21 2015, 3:47 PM
K-ballo retitled D7096: Fix isTriviallyCopyableType for arrays from to Fix isTriviallyCopyableType for arrays.
Jan 21 2015, 8:25 AM
K-ballo added a comment to D7060: Implement CWG496: Is a volatile-qualified type really a POD?.

Any suggestions on what to do with the failing testcase (CodeGenCXX/no-opt-volatile-memcpy.cpp)? This test checks that the issued @llvm.memcpy has isvolatile=true, but after this patch memcpy is no longer issued as those operations are no longer considered trivial. This could suggest that memcpy with isvolatile=true should still be used in those cases (albeit the docs say "it is unwise to depend on it"), or that there is dead code out there looking for volatile members in trivial operations.

Jan 21 2015, 6:43 AM

Jan 20 2015

K-ballo updated the diff for D5942: [libcxx] Support UDTs convertible to arithmetic types in <cmath>.

Addressed review comments. Keep in mind that only pow is implemented completely, once we get that one right I'll update the others to follow.

Jan 20 2015, 12:37 PM

Jan 19 2015

K-ballo retitled D7060: Implement CWG496: Is a volatile-qualified type really a POD? from to Implement CWG496: Is a volatile-qualified type really a POD?.
Jan 19 2015, 1:04 PM

Jan 14 2015

K-ballo updated the diff for D6964: [libcxx] SFINAE-friendly common_type.

Updated test to work under C++03 mode

Jan 14 2015, 11:59 AM
K-ballo added inline comments to D6964: [libcxx] SFINAE-friendly common_type.
Jan 14 2015, 5:51 AM
K-ballo retitled D6964: [libcxx] SFINAE-friendly common_type from to [libcxx] SFINAE-friendly common_type.
Jan 14 2015, 5:47 AM

Oct 31 2014

K-ballo added a comment to D5942: [libcxx] Support UDTs convertible to arithmetic types in <cmath>.

This patch reverts the incorporation of __lazy_enable_if, as this is a more general solution. It implements __numeric_type in a SFINAE-friendly fashion, which will flag ambiguously convertible UDTs (as well as other soft errors) as non-numeric types.

Oct 31 2014, 10:19 AM
K-ballo added a comment to D5127: [libcxx] Initializer list support for MSVC.

Do we need tests for this change?

Oct 31 2014, 9:28 AM

Oct 23 2014

K-ballo retitled D5942: [libcxx] Support UDTs convertible to arithmetic types in <cmath> from to [libcxx] Support UDTs convertible to arithmetic types in <cmath>.
Oct 23 2014, 2:24 PM

Oct 22 2014

K-ballo added a comment to D4467: [libcxx] Delay evaluation of __make_tuple_types to prevent blowing the max template instantiation depth. Fixes Bug #18345.

Looks good to me. Some notes attached.

Oct 22 2014, 3:20 PM

Oct 14 2014

K-ballo closed D5430: MS ABI: Avoid hashing back reference keys in mangler.

Landed in rL218461

Oct 14 2014, 11:51 AM

Oct 11 2014

K-ballo added inline comments to D5742: [libcxx] Add <experimental/type_traits> for LFTS.
Oct 11 2014, 11:55 AM

Oct 9 2014

K-ballo retitled D5710: [libcxx] Fix SFINAE in <cmath> from to [libcxx] Fix SFINAE in <cmath>.
Oct 9 2014, 12:57 PM

Sep 22 2014

K-ballo updated the diff for D5430: MS ABI: Avoid hashing back reference keys in mangler.

Addressed review comments

Sep 22 2014, 11:10 AM

Sep 21 2014

K-ballo retitled D5430: MS ABI: Avoid hashing back reference keys in mangler from to MS ABI: Avoid hashing back reference keys in mangler.
Sep 21 2014, 12:36 PM

Aug 30 2014

K-ballo updated the diff for D5126: [libcxx] Emulation of atomic builtins for MSVC.

Use _LIBCPP_ALWAYS_INLINE as it seems a better choice.

Aug 30 2014, 7:26 AM

Aug 29 2014

K-ballo added inline comments to D5133: [libcxx] type_info support for MSVC.
Aug 29 2014, 7:32 PM
K-ballo retitled D5133: [libcxx] type_info support for MSVC from to [libcxx] type_info support for MSVC.
Aug 29 2014, 4:37 PM
K-ballo retitled D5131: [libcxx] unexpected/terminate support for MS CRT from unexpected/terminate support for MS CRT to [libcxx] unexpected/terminate support for MS CRT.
Aug 29 2014, 4:32 PM
K-ballo added inline comments to D5131: [libcxx] unexpected/terminate support for MS CRT.
Aug 29 2014, 2:51 PM
K-ballo retitled D5131: [libcxx] unexpected/terminate support for MS CRT from to unexpected/terminate support for MS CRT.
Aug 29 2014, 2:48 PM
K-ballo retitled D5127: [libcxx] Initializer list support for MSVC from to [libcxx] Initializer list support for MSVC.
Aug 29 2014, 12:23 PM
K-ballo retitled D5126: [libcxx] Emulation of atomic builtins for MSVC from to [libcxx] Emulation of atomic builtins for MSVC.
Aug 29 2014, 12:09 PM

Jul 30 2014

K-ballo added inline comments to D4735: [libcxx] Remove use of default function template parameters in type traits. Fixes DR20484.
Jul 30 2014, 7:30 PM

Jul 12 2014

K-ballo added a comment to D4467: [libcxx] Delay evaluation of __make_tuple_types to prevent blowing the max template instantiation depth. Fixes Bug #18345.

Have you considered a non-recursive implementation of __tuple_constructible_imp? For instance, checking whether foo(declval<Up>()...) is well-formed given void foo(Tp...).

Jul 12 2014, 9:19 PM

Jul 10 2014

K-ballo added inline comments to D4341: [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics.
Jul 10 2014, 1:13 PM · deleted

Jun 26 2014

K-ballo added a comment to D4306: Fix for libc++ bug #20096 http://llvm.org/bugs/show_bug.cgi?id=20096.

The existing implementation is the correct one for C++11, where is_destructible<T> is defined as:

Jun 26 2014, 7:46 AM

Jun 25 2014

K-ballo added a comment to D4130: Avoid extra back reference key lookup in msmangler.
In D4130#13, @rnk wrote:

Do you need me to commit this for you?

Jun 25 2014, 6:41 PM

Jun 24 2014

K-ballo updated the diff for D4130: Avoid extra back reference key lookup in msmangler.

Changes in this iteration:

Jun 24 2014, 11:54 AM

Jun 19 2014

K-ballo updated the diff for D4153: Add standard insert overloads to StringMap.

Changes in this iteration:

Jun 19 2014, 12:37 PM
K-ballo added inline comments to D4153: Add standard insert overloads to StringMap.
Jun 19 2014, 11:43 AM
K-ballo added inline comments to D4153: Add standard insert overloads to StringMap.
Jun 19 2014, 11:08 AM

Jun 16 2014

K-ballo updated the diff for D4153: Add standard insert overloads to StringMap.

Changes in this iteration:

Jun 16 2014, 6:08 PM
K-ballo added a comment to D4153: Add standard insert overloads to StringMap.

I would like to add a test case that triggers a table rehash but I'm not sure how to do that, suggestions?

Not sure, actually. It looks like the growth function is the usual sort of thing, so probably just inserting a second element should cause a rehash - no?

Jun 16 2014, 3:36 PM
K-ballo updated the diff for D4153: Add standard insert overloads to StringMap.

Changes in this iteration:

Jun 16 2014, 2:48 PM
K-ballo added a comment to D4153: Add standard insert overloads to StringMap.

In the other code review you mention StringMap has an insert that
returns bool? Yet you're not modifying that version here? What
arguments does it take that make it distinct from the two functions
you're adding?

The existing insert is defined as bool insert(MapEntryTy *KeyValue), it takes a pointer to an already created MapEntryTy and acquires ownership of it. AFAIK, this is the only piece of functionality that would not be covered by a standard associative sequence interface.

Do any of the callers (at a glance) do anything fancy with this? Do they get a pre-allocated MapEntryTy object from somewhere far flung (from another map, from this map under another key, etc) - or do they just allocate it and pass it in immediately?

If it doesn't seem to add any value, it'd be nice to remove it (eventually - that task doesn't have to be yours to bear, but if it looks like that's the right path then a FIXME comment suggesting that direction could be useful).

Jun 16 2014, 1:12 PM
K-ballo added a comment to D4153: Add standard insert overloads to StringMap.
In D4153#4, @dblaikie wrote:

The test case looks a bit thin - it doesn't test the return value of
insert, only tests one of the two insert functions the patch
introduces, and doesn't test positive and negative cases of insert
(pre-existing element and new insertion)

Jun 16 2014, 12:15 PM

Jun 15 2014

K-ballo added a comment to D4130: Avoid extra back reference key lookup in msmangler.

I think that instead of introducing a new function I should just be using mangleSourceName. A template instantiation name is a source name too (considering anonymous type names are treated as source names), it's just that their terminating '@' is currently being added at the end of the template argument list. If the argument list no longer appends the '@', then they would be treated as any other source name.

Jun 15 2014, 9:18 PM
K-ballo retitled D4153: Add standard insert overloads to StringMap from to Add standard insert overloads to StringMap.
Jun 15 2014, 6:17 PM
K-ballo planned changes to D4130: Avoid extra back reference key lookup in msmangler.
In D4130#6, @timurrrr wrote:

Is it hard to add that function to the interface?

Jun 15 2014, 12:58 PM
K-ballo added inline comments to D4130: Avoid extra back reference key lookup in msmangler.
Jun 15 2014, 11:53 AM

Jun 14 2014

K-ballo closed D3983: Simplify microsoft mangling of template instantiations.
Jun 14 2014, 12:22 PM
K-ballo accepted D3983: Simplify microsoft mangling of template instantiations.

Commited in r210416.

Jun 14 2014, 12:21 PM

Jun 12 2014

K-ballo retitled D4130: Avoid extra back reference key lookup in msmangler from to Avoid extra back reference key lookup in msmangler.
Jun 12 2014, 5:12 PM

Jun 6 2014

K-ballo updated the diff for D3983: Simplify microsoft mangling of template instantiations.

Renamed BackReferenceKey to TemplateMangling

Jun 6 2014, 8:06 AM