Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
test/CodeGen/X86/abi-isel.ll | ||
---|---|---|
1 | We have an option, I forget the precise name, -x86_no_scrub_rip, or something like that, that retains address math. I think I used that last time I regenerated this or some other global access .ll test cases. I think it's important to have some instructions for how to update this test case in the future, so can you look into that? If it's only a small change to the scrubber to retain this address arithmetic, that would be worth doing. |
Comment Actions
lgtm
For a while now I've wanted to add logic to update_llc_test_checks to write its flags into the test file and pull them back out again when run with no flags, but that day is not today.
We have an option, I forget the precise name, -x86_no_scrub_rip, or something like that, that retains address math. I think I used that last time I regenerated this or some other global access .ll test cases. I think it's important to have some instructions for how to update this test case in the future, so can you look into that? If it's only a small change to the scrubber to retain this address arithmetic, that would be worth doing.