This is an archive of the discontinued LLVM Phabricator instance.

[X86] Fix linux32 pic tests to use correct relocation model (PR39684)
ClosedPublic

Authored by RKSimon on Jan 27 2019, 8:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Jan 27 2019, 8:52 AM
rnk added inline comments.Jan 28 2019, 10:03 AM
test/CodeGen/X86/abi-isel.ll
1 ↗(On Diff #183756)

We have an option, I forget the precise name, -x86_no_scrub_rip, or something like that, that retains address math. I think I used that last time I regenerated this or some other global access .ll test cases. I think it's important to have some instructions for how to update this test case in the future, so can you look into that? If it's only a small change to the scrubber to retain this address arithmetic, that would be worth doing.

RKSimon updated this revision to Diff 183906.Jan 28 2019, 10:33 AM
RKSimon edited the summary of this revision. (Show Details)

Regenerate with the --no_x86_scrub_rip argument and add a note explaining why.

sbc100 accepted this revision.Jan 28 2019, 12:34 PM
This revision is now accepted and ready to land.Jan 28 2019, 12:34 PM
rnk accepted this revision.Jan 28 2019, 1:00 PM

lgtm

For a while now I've wanted to add logic to update_llc_test_checks to write its flags into the test file and pull them back out again when run with no flags, but that day is not today.

This revision was automatically updated to reflect the committed changes.