This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [Process/NetBSD] Add missing linkage to -lutil
ClosedPublic

Authored by mgorny on Jan 24 2019, 2:15 PM.

Download Raw Diff

Details

Reviewers

Commits

rG24479b1157d3: Merging r352116: --------------------------------------------------------------…
rGa228ab524f78: [Process/NetBSD] Add missing linkage to -lutil
rL352134: Merging r352116:
rLLDB352116: [Process/NetBSD] Add missing linkage to -lutil
rL352116: [Process/NetBSD] Add missing linkage to -lutil

Summary

Add missing linkage to fix build failure with LLD:

ld: error: undefined symbol: kinfo_getvmmap
>>> referenced by NativeProcessNetBSD.cpp
>>>               NativeProcessNetBSD.cpp.o:(lldb_private::process_netbsd::NativeProcessNetBSD::PopulateMemoryRegionCache()) in archive lib/liblldbPluginProcessNetBSD.a

Diff Detail

Repository: rL LLVM

Event Timeline

mgorny created this revision.Jan 24 2019, 2:15 PM

Herald added a subscriber: abidh. · View Herald TranscriptJan 24 2019, 2:15 PM

krytarowski accepted this revision.Jan 24 2019, 2:17 PM

This revision is now accepted and ready to land.Jan 24 2019, 2:17 PM

Closed by commit rL352116: [Process/NetBSD] Add missing linkage to -lutil (authored by mgorny). · Explain WhyJan 24 2019, 2:22 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 24 2019, 2:22 PM

Revision Contents

Path

Size

lldb/

trunk/

source/

Plugins/

Process/

NetBSD/

CMakeLists.txt

1 line

Diff 183400

lldb/trunk/source/Plugins/Process/NetBSD/CMakeLists.txt

	add_lldb_library(lldbPluginProcessNetBSD PLUGIN			add_lldb_library(lldbPluginProcessNetBSD PLUGIN
	NativeProcessNetBSD.cpp			NativeProcessNetBSD.cpp
	NativeRegisterContextNetBSD.cpp			NativeRegisterContextNetBSD.cpp
	NativeRegisterContextNetBSD_x86_64.cpp			NativeRegisterContextNetBSD_x86_64.cpp
	NativeThreadNetBSD.cpp			NativeThreadNetBSD.cpp

	LINK_LIBS			LINK_LIBS
	lldbHost			lldbHost
	lldbSymbol			lldbSymbol
	lldbTarget			lldbTarget
	lldbUtility			lldbUtility
	lldbPluginProcessPOSIX			lldbPluginProcessPOSIX
	lldbPluginProcessUtility			lldbPluginProcessUtility
				util
	LINK_COMPONENTS			LINK_COMPONENTS
	Support			Support
	)			)