Page MenuHomePhabricator

[RS4GC] Be slightly less conservative for gep vector_base, scalar_idx
ClosedPublic

Authored by reames on Jan 24 2019, 8:20 AM.

Details

Summary

After submitting https://reviews.llvm.org/D57138, I realized it was slightly more conservative than needed. The scalar indices don't appear to be a problem on a scalar gep, we even had a test for that.

Diff Detail

Repository
rL LLVM

Event Timeline

reames created this revision.Jan 24 2019, 8:20 AM
anna added a comment.Jan 24 2019, 8:29 AM

The scalar indices don't appear to be a problem on a scalar gep, we even had a test for that.

just to note it is not a scalar gep - this is a vector gep which has a scalar index.

anna accepted this revision.Jan 24 2019, 8:31 AM

lgtm.

This revision is now accepted and ready to land.Jan 24 2019, 8:31 AM
This revision was automatically updated to reflect the committed changes.