This is an archive of the discontinued LLVM Phabricator instance.

Add missing include (cstdlib) to Demangle.h
ClosedPublic

Authored by kzhuravl on Jan 21 2019, 1:33 PM.

Details

Diff Detail

Event Timeline

kzhuravl created this revision.Jan 21 2019, 1:33 PM
This revision is now accepted and ready to land.Jan 21 2019, 5:13 PM

LGTM, if it is moved into Demangle.cpp. I don't think we want to be adding unnecessary dependencies to headers, when a .cpp file change would suffice.

include/llvm/Demangle/Demangle.h
13

Shouldn't this be in Demangle.cpp, since the only usage is there?

kzhuravl marked an inline comment as done.Jan 22 2019, 10:44 AM

Will fix during committing. Thanks.

This revision was automatically updated to reflect the committed changes.