This is an archive of the discontinued LLVM Phabricator instance.

[docs] Add release notes for notable things I've contributed since last release
ClosedPublic

Authored by mstorsjo on Jan 21 2019, 1:38 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Jan 21 2019, 1:38 AM
mstorsjo marked an inline comment as done.Jan 21 2019, 1:40 AM
mstorsjo added inline comments.
docs/ReleaseNotes.rst
190 ↗(On Diff #182754)

This comment doesn't really say much for the casual reader, perhaps it should just be left out and regarded as general assorted bugfixes? Although the fix (D55698) is a notable step towards matching GCC better for MinGW, and fixes an actual issue (building Qt in debug mode).

hans accepted this revision.Jan 22 2019, 10:15 AM
hans added inline comments.
docs/ReleaseNotes.rst
190 ↗(On Diff #182754)

I think keeping it in is fine. If you want you could of course expand with mentioning the Qt part of your comment and maybe link to a bug entry if applicable.

This revision is now accepted and ready to land.Jan 22 2019, 10:15 AM
rnk added inline comments.Jan 22 2019, 10:24 AM
docs/ReleaseNotes.rst
190 ↗(On Diff #182754)

I agree, I think the info about Qt is the kind of newsworthy thing users will want to know and will understand.

This revision was automatically updated to reflect the committed changes.