This is an archive of the discontinued LLVM Phabricator instance.

gn build: Stop passing -DLLVM_LIBXML2_ENABLED to some targets
ClosedPublic

Authored by thakis on Jan 18 2019, 7:42 AM.

Details

Summary

This is a remnant from before the gn build had a working config.h.

Defining LLVM_LIBXML2_ENABLED only for targets that depend on build/libs/xml is nice in that only some of the codebase needs to be rebuilt when llvm_enable_libxml2 changes -- but config.h already defines it and defining it there and then redundantly a second time for some targets is worse than having it just in config.h.

No behavior change.

Diff Detail

Event Timeline

thakis created this revision.Jan 18 2019, 7:42 AM
phosek accepted this revision.Jan 20 2019, 4:32 PM

LGTM

This revision is now accepted and ready to land.Jan 20 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.