This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add a one use check to the setcc inversion code in combineVSelectWithAllOnesOrZeros
ClosedPublic

Authored by craig.topper on Jan 15 2019, 5:22 PM.

Details

Summary

If we're going to generate a new inverted setcc, we should make sure we will be able to remove the old setcc.

This found in a larger test case from a coworker I haven't had a chance to reduce yet.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 15 2019, 5:22 PM
RKSimon accepted this revision.Jan 16 2019, 1:55 AM

LGTM but a test case would be useful.

lib/Target/X86/X86ISelLowering.cpp
33851

Update comment?

This revision is now accepted and ready to land.Jan 16 2019, 1:55 AM
This revision was automatically updated to reflect the committed changes.