This is an archive of the discontinued LLVM Phabricator instance.

gn build: Don't assume valgrind.h exists on Linux
ClosedPublic

Authored by hans on Jan 15 2019, 8:44 AM.

Details

Summary

It didn't on my machine, so defaulting it to off seems better.

Diff Detail

Repository
rL LLVM

Event Timeline

hans created this revision.Jan 15 2019, 8:44 AM
thakis accepted this revision.Jan 15 2019, 8:46 AM

Thanks!

llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
94 ↗(On Diff #181796)

since this is now set unconditionally, can you put it in this block of unconditionally set things?

This revision is now accepted and ready to land.Jan 15 2019, 8:46 AM
hans marked an inline comment as done.Jan 15 2019, 8:53 AM

Will do.

This revision was automatically updated to reflect the committed changes.