[libcxx] Portability fix: add missing includes.

[amakc11]

Summary

Some tests use strcmp() function, but do not include the string.h header directly. As a result, such tests do not compile under some conformant implementations. This patch adds the mentioned header file to such tests.

[EricWF]

test/std/input.output/stream.buffers/streambuf/streambuf.virtuals/streambuf.virt.get/xsgetn.pass.cpp

19

<cstring> instead?

[amakc11]

test/std/input.output/stream.buffers/streambuf/streambuf.virtuals/streambuf.virt.get/xsgetn.pass.cpp

19

Why? Please, provide reasoning in the context of this very test. My reasoning, for example, is: in standard <string.h> defines strcmp(), <cstring> defines std::strcmp(), this very test uses the first variant of the function call.

[amakc11]

ping

[ldionne]

Please #include <cstring> and switch to std::strcmp instead.

[amakc11]

For complete consistency with this request, two more tests were patched. Calls to strcmp() replaced with std::strcmp() and <cstring> header added according to the requirement of the standard. The test std/depr/depr.c.headers/string_h.pass.cpp remains untouched since it checks the requirements to <string.h> header.

[ldionne]

Thanks!

[ldionne]

Committed as r351847.

test/std/depr/depr.str.strstreams/depr.strstream/depr.strstream.cons/default.pass.cpp

 // <strstream>
 
 // class strstream
 
 // strstream();
 
 #include <strstream>
 #include <cassert>
+#include <cstring>
 #include <string>
 
 int main()
 {
     std::strstream inout;
     int i = 123;
     double d = 4.5;
     std::string s("dog");
     inout << i << ' ' << d << ' ' << s << std::ends;
     assert(inout.str() == std::string("123 4.5 dog"));
     i = 0;
     d = 0;
     s = "";
     inout >> i >> d >> s;
     assert(i == 123);
     assert(d == 4.5);
-    assert(strcmp(s.c_str(), "dog") == 0);
+    assert(std::strcmp(s.c_str(), "dog") == 0);
     inout.freeze(false);
 }

test/std/input.output/stream.buffers/streambuf/streambuf.virtuals/streambuf.virt.get/xsgetn.pass.cpp

 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_streambuf;
 
 // streamsize xsgetn(char_type* s, streamsize n);
 
 #include <streambuf>
 #include <cassert>
+#include <cstring>
 
 struct test
     : public std::basic_streambuf<char>
 {
     typedef std::basic_streambuf<char> base;
 
     test() {}
 
     void setg(char* gbeg, char* gnext, char* gend)
     {
         base::setg(gbeg, gnext, gend);
     }
 };
 
 int main()
 {
     test t;
     char input[7] = "123456";
     t.setg(input, input, input+7);
     char output[sizeof(input)] = {0};
     assert(t.sgetn(output, 10) == 7);
-    assert(strcmp(input, output) == 0);
+    assert(std::strcmp(input, output) == 0);
 }

test/std/input.output/stream.buffers/streambuf/streambuf.virtuals/streambuf.virt.put/xsputn.pass.cpp

 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_streambuf;
 
 // streamsize xsputn(const char_type* s, streamsize n);
 
 #include <streambuf>
 #include <cassert>
+#include <cstring>
 
 struct test
     : public std::basic_streambuf<char>
 {
     typedef std::basic_streambuf<char> base;
 
     test() {}
 
     void setp(char* pbeg, char* pend)
     {
         base::setp(pbeg, pend);
     }
 };
 
 int main()
 {
     {
         test t;
         char in[] = "123456";
         assert(t.sputn(in, sizeof(in)) == 0);
         char out[sizeof(in)] = {0};
         t.setp(out, out+sizeof(out));
         assert(t.sputn(in, sizeof(in)) == sizeof(in));
-        assert(strcmp(in, out) == 0);
+        assert(std::strcmp(in, out) == 0);
     }
 }

test/std/language.support/support.rtti/type.info/type_info.pass.cpp

 {
   {
     const std::type_info& t1 = typeid(int);
     const std::type_info& t2 = typeid(int);
     assert(t1 == t2);
     const std::type_info& t3 = typeid(short);
     assert(t1 != t3);
     assert(!t1.before(t2));
-    assert(strcmp(t1.name(), t2.name()) == 0);
-    assert(strcmp(t1.name(), t3.name()) != 0);
+    assert(std::strcmp(t1.name(), t2.name()) == 0);
+    assert(std::strcmp(t1.name(), t3.name()) != 0);
   }
   {
     // type_info has a protected constructor taking a string literal. This
     // constructor is not intended for users. However it still participates
     // in overload resolution, so we need to ensure that it is marked explicit
     // to avoid ambiguous conversions.
     // See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216201
     assert(test_constructor_explicit("abc"));
   }
 }