This is an archive of the discontinued LLVM Phabricator instance.

gn build: Stop passing -o to ar.
ClosedPublic

Authored by pcc on Jan 7 2019, 7:34 PM.

Details

Summary

The -o flag means something different to ar than what appears to be
intended here. Also, llvm-ar doesn't accept the flag in this position.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Jan 7 2019, 7:34 PM
phosek accepted this revision.Jan 7 2019, 8:00 PM

LGTM

This revision is now accepted and ready to land.Jan 7 2019, 8:00 PM
This revision was automatically updated to reflect the committed changes.
thakis added a comment.Jan 9 2019, 5:00 AM

Thanks for the patch! Please run git ls-files '*.gn' '*.gni' | xargs -n 1 gn format after making GN changes. (I forgot that for the PowerPC target too, so I'm running it for this file here too, so nothing to do for you, just pointing it out for next time.)