This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Make vector types legal in UREM test
ClosedPublic

Authored by hermord on Jan 6 2019, 5:41 PM.

Details

Summary

As discussed in D50222, this changes the vector types in tests required for that revision to ones legal for X86.

Diff Detail

Repository
rL LLVM

Event Timeline

hermord created this revision.Jan 6 2019, 5:41 PM
RKSimon accepted this revision.Jan 7 2019, 2:58 AM

LGTM - I don't have a problem if you want to keep both the v4i16 + v8i16 tests for aarch64 where they are both legal

This revision is now accepted and ready to land.Jan 7 2019, 2:58 AM

@hermord Are you intending to commit this?

@RKSimon Sorry, I should have mentioned in the summary that I don't have commit rights.

@RKSimon Sorry, I should have mentioned in the summary that I don't have commit rights.

OK - do you want to put the (aarch64 only) 64-bit vector tests back (as well as the 128-bit)?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2019, 11:38 AM