Page MenuHomePhabricator

[HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types
ClosedPublic

Authored by ashi1 on Jan 4 2019, 8:40 AM.

Details

Summary

The offload bundler action should not unbundle the input file types that does not match the action type. This fixes an issue where .so files are unbundled when the action type is object files.

Diff Detail

Event Timeline

ashi1 created this revision.Jan 4 2019, 8:40 AM
ashi1 added a subscriber: Restricted Project.Jan 4 2019, 8:41 AM
yaxunl accepted this revision.Jan 4 2019, 11:04 AM

LGTM. Can you rename the lit test as hip-link-shared-library.hip? That is more meaningful. Thanks.

This revision is now accepted and ready to land.Jan 4 2019, 11:04 AM
This revision was automatically updated to reflect the committed changes.
ashi1 updated this revision to Diff 180289.Jan 4 2019, 11:18 AM

I've commit the changes, but forgot to tag the proper Diff link in the commit message. I just updated it.