[SemaCXX] Fix ICE for unexpanded parameter pack

[modocache]

Summary

The documentation for RecursiveASTVisitor::TraverseDecl states that the
Decl being traversed may be null. In fact, this is the case when a
CXXCatchStmt with no exception decl is traversed. Because the visitor
for diagnosing unexpanded parameter packs does not check for null, it
ends up crashing when it attempts to call the Decl::isParameterPack
method on a null Decl pointer.

Add a null check to prevent an ICE, and a test case that would crash
otherwise. Also, because the test requires C++ exceptions and C++14,
change the test parameters for the entire test file. (Alternatively, I
thought about adding a new test file, but went with this approach for my
own convenience.)

Co-authored-by: Andreas Molzer <[e-mail]>
Co-authored-by: Mara Bos <[e-mail]>

[rsmith]

Looks good, thank you!

[modocache]

Thank you for the review!

cfe/trunk/lib/Sema/SemaTemplateVariadic.cpp

bool TraverseTypeLoc(TypeLoc TL) {
       return true;
     }
 
     /// Suppress traversal of parameter packs.
     bool TraverseDecl(Decl *D) {
       // A function parameter pack is a pack expansion, so cannot contain
       // an unexpanded parameter pack. Likewise for a template parameter
       // pack that contains any references to other packs.
-      if (D->isParameterPack())
+      if (D && D->isParameterPack())
         return true;
 
       return inherited::TraverseDecl(D);
     }
 
     /// Suppress traversal of pack-expanded attributes.
     bool TraverseAttr(Attr *A) {
       if (A->isPackExpansion())

cfe/trunk/test/SemaCXX/alias-template.cpp

-// RUN: %clang_cc1 -verify -std=c++11 %s
+// RUN: %clang_cc1 -verify -std=c++14 -fcxx-exceptions %s
 
 namespace RedeclAliasTypedef {
   template<typename U> using T = int;
   template<typename U> using T = int;
   template<typename U> using T = T<U>;
 }
 
 namespace IllegalTypeIds {

 template <class T>
 using void_t = void;
 
 template <class T, class = void_t<typename T::wait_what>>
 int sfinae_me() { return 0; } // expected-note{{candidate template ignored: substitution failure}}
 
 int g = sfinae_me<int>(); // expected-error{{no matching function for call to 'sfinae_me'}}
 }
+
+namespace NullExceptionDecl {
+template<int... I> auto get = []() { try { } catch(...) {}; return I; }; // expected-error{{initializer contains unexpanded parameter pack 'I'}}
+}