This is an archive of the discontinued LLVM Phabricator instance.

Differential D56262

Python compat - isinstance(x, long)
ClosedPublic

Authored by serge-sans-paille on Jan 3 2019, 3:27 AM.

Details

Reviewers
michaelplatings
Commits
rGbd6769df27e7: Python compat - test if type is integral
rL350316: Python compat - test if type is integral

Diff Detail

Event Timeline

serge-sans-paille created this revision.Jan 3 2019, 3:27 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 3 2019, 3:27 AM
michaelplatings accepted this revision.Jan 3 2019, 4:48 AM

LGTM

This revision is now accepted and ready to land.Jan 3 2019, 4:48 AM
Closed by commit rL350316: Python compat - test if type is integral (authored by serge_sans_paille). · Explain WhyJan 3 2019, 6:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
bindings/
python/
llvm/
tests/
16 lines

Diff 180026

bindings/python/llvm/tests/test_object.py

from numbers import Integral
from .base import TestBase from .base import TestBase
from ..object import ObjectFile from ..object import ObjectFile
from ..object import Relocation from ..object import Relocation
Context not available.
count += 1 count += 1
assert isinstance(section, Section) assert isinstance(section, Section)
assert isinstance(section.name, str) assert isinstance(section.name, str)
assert isinstance(section.size, long) assert isinstance(section.size, Integral)
assert isinstance(section.contents, str) assert isinstance(section.contents, str)
assert isinstance(section.address, long) assert isinstance(section.address, Integral)
assert len(section.contents) == section.size assert len(section.contents) == section.size
self.assertGreater(count, 0) self.assertGreater(count, 0)
Context not available.
count += 1 count += 1
assert isinstance(symbol, Symbol) assert isinstance(symbol, Symbol)
assert isinstance(symbol.name, str) assert isinstance(symbol.name, str)
assert isinstance(symbol.address, long) assert isinstance(symbol.address, Integral)
assert isinstance(symbol.size, long) assert isinstance(symbol.size, Integral)
self.assertGreater(count, 0) self.assertGreater(count, 0)
Context not available.
for section in o.get_sections(): for section in o.get_sections():
for relocation in section.get_relocations(): for relocation in section.get_relocations():
assert isinstance(relocation, Relocation) assert isinstance(relocation, Relocation)
assert isinstance(relocation.address, long) assert isinstance(relocation.address, Integral)
assert isinstance(relocation.offset, long) assert isinstance(relocation.offset, Integral)
assert isinstance(relocation.type_number, long) assert isinstance(relocation.type_number, Integral)
assert isinstance(relocation.type_name, str) assert isinstance(relocation.type_name, str)
assert isinstance(relocation.value_string, str) assert isinstance(relocation.value_string, str)
Context not available.