This is an archive of the discontinued LLVM Phabricator instance.

Differential D56257

Python compat - iteritems
ClosedPublic

Authored by serge-sans-paille on Jan 3 2019, 3:23 AM.

Details

Reviewers
michaelplatings
Commits
rG873cba17b286: Python compat - iteritems() vs. items()
rL350312: Python compat - iteritems() vs. items()

Diff Detail

Event Timeline

serge-sans-paille created this revision.Jan 3 2019, 3:23 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 3 2019, 3:23 AM
michaelplatings accepted this revision.Jan 3 2019, 4:58 AM

LGTM

This revision is now accepted and ready to land.Jan 3 2019, 4:58 AM
Closed by commit rL350312: Python compat - iteritems() vs. items() (authored by serge_sans_paille). · Explain WhyJan 3 2019, 6:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tools/
llvm-readobj/
Inputs/
2 lines
utils/
Reviewing/
4 lines
docker/
scripts/
llvm_checksum/
2 lines

Diff 180020

test/tools/llvm-readobj/Inputs/relocs.py

Context not available.
def makeKey(item): def makeKey(item):
return (item[1], item[0]) return (item[1], item[0])
e = [] e = []
for pair in sorted(self._nameMap.iteritems(), key=makeKey): for pair in sorted(self._nameMap.items(), key=makeKey):
e.append(pair) e.append(pair)
return e return e
Context not available.

utils/Reviewing/find_interesting_reviews.py

Context not available.
return self.id2PhabObjects[id] return self.id2PhabObjects[id]
def get_ids_in_cache(self): def get_ids_in_cache(self):
return self.id2PhabObjects.keys() return list(self.id2PhabObjects.keys())
def get_objects(self): def get_objects(self):
return self.id2PhabObjects.values() return list(self.id2PhabObjects.values())
DEFAULT_DIRECTORY = "PhabObjectCache" DEFAULT_DIRECTORY = "PhabObjectCache"
Context not available.

utils/docker/scripts/llvm_checksum/llvm_checksum.py

Context not available.
if len(new_checksums) != len(reference_checksums): if len(new_checksums) != len(reference_checksums):
return False return False
for proj, checksum in new_checksums.iteritems(): for proj, checksum in new_checksums.items():
# We never computed a checksum for this project. # We never computed a checksum for this project.
if proj not in reference_checksums: if proj not in reference_checksums:
return False return False
Context not available.