This is an archive of the discontinued LLVM Phabricator instance.

Differential D56251

python compat - assertraisesregex
ClosedPublic

Authored by serge-sans-paille on Jan 3 2019, 3:19 AM.

Details

Reviewers
michaelplatings
Commits
rG707fab58a985: Python compat - assertRaisesRegex
rL350308: Python compat - assertRaisesRegex

Diff Detail

Repository
rL LLVM

Event Timeline

serge-sans-paille created this revision.Jan 3 2019, 3:19 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 3 2019, 3:19 AM
michaelplatings requested changes to this revision.Jan 3 2019, 5:06 AM
michaelplatings added inline comments.
bindings/python/llvm/tests/base.py
21

I think this should be:
assertRaisesRegex = unittest.TestCase.assertRaisesRegexp

This revision now requires changes to proceed.Jan 3 2019, 5:06 AM
serge-sans-paille marked an inline comment as done.Jan 3 2019, 5:42 AM
serge-sans-paille added inline comments.
bindings/python/llvm/tests/base.py
21

Well It's actually the same as TestBase inherits from unittest.TestCase.

I prefer this form because it makes the renaming more explicit.

michaelplatings added inline comments.Jan 3 2019, 5:52 AM
bindings/python/llvm/tests/base.py
21

Doesn't work for me:
NameError: name 'TestBase' is not defined

serge-sans-paille updated this revision to Diff 180045.Jan 3 2019, 6:00 AM
michaelplatings accepted this revision.Jan 3 2019, 6:01 AM

LGTM

This revision is now accepted and ready to land.Jan 3 2019, 6:01 AM
Closed by commit rL350308: Python compat - assertRaisesRegex (authored by serge_sans_paille). · Explain WhyJan 3 2019, 6:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
bindings/
python/
llvm/
tests/
5 lines
2 lines

Diff 180014

bindings/python/llvm/tests/base.py

import os.path import os.path
import sys
import unittest import unittest
POSSIBLE_TEST_BINARIES = [ POSSIBLE_TEST_BINARIES = [
'libreadline.so.5', 'libreadline.so.5',
'libreadline.so.6', 'libreadline.so.6',
Context not available.
] ]
class TestBase(unittest.TestCase): class TestBase(unittest.TestCase):
if sys.version_info.major == 2:
assertRaisesRegex = TestBase.assertRaisesRegexp
michaelplatingsUnsubmitted
Not Done
ReplyInline Actions

I think this should be:
assertRaisesRegex = unittest.TestCase.assertRaisesRegexp

michaelplatings: I think this should be: assertRaisesRegex = unittest.TestCase.assertRaisesRegexp
serge-sans-pailleAuthorUnsubmitted
Done
ReplyInline Actions

Well It's actually the same as TestBase inherits from unittest.TestCase.

I prefer this form because it makes the renaming more explicit.

serge-sans-paille: Well It's actually the same as `TestBase` inherits from `unittest.TestCase`. I prefer this…
michaelplatingsUnsubmitted
Not Done
ReplyInline Actions

Doesn't work for me:
NameError: name 'TestBase' is not defined

michaelplatings: Doesn't work for me: NameError: name 'TestBase' is not defined
def get_test_binary(self): def get_test_binary(self):
"""Helper to obtain a test binary for object file testing. """Helper to obtain a test binary for object file testing.
Context not available.

bindings/python/llvm/tests/test_disassembler.py

Context not available.
self.assertEqual(s, '\tjcxz\t-127') self.assertEqual(s, '\tjcxz\t-127')
def test_nonexistent_triple(self): def test_nonexistent_triple(self):
with self.assertRaisesRegexp(Exception, "Could not obtain disassembler for triple"): with self.assertRaisesRegex(Exception, "Could not obtain disassembler for triple"):
Disassembler("nonexistent-triple-raises") Disassembler("nonexistent-triple-raises")
def test_get_instructions(self): def test_get_instructions(self):
Context not available.