Page MenuHomePhabricator

[llvm] Clarify responsiblity of some of DILocation discriminator APIs
ClosedPublic

Authored by mtrofin on Jan 2 2019, 1:29 PM.

Details

Summary

Renamed setBaseDiscriminator to cloneWithBaseDiscriminator, to match
similar APIs. Also changed its behavior to copy over the other
discriminator components, instead of eliding them.

Renamed cloneWithDuplicationFactor to
cloneByMultiplyingDuplicationFactor, which more closely matches what
this API does.

Diff Detail

Repository
rL LLVM

Event Timeline

mtrofin created this revision.Jan 2 2019, 1:29 PM
dblaikie accepted this revision.Jan 23 2019, 11:46 AM

Seems good - thanks!

This revision is now accepted and ready to land.Jan 23 2019, 11:46 AM
This revision was automatically updated to reflect the committed changes.