This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Add build file for clang/lib/Parse
ClosedPublic

Authored by thakis on Dec 20 2018, 6:05 AM.

Details

Summary

Nothing really interesting. One thing to consider is where the clang_tablegen() invocations that generate files that are private to a library should be. The CMake build puts them in clang/include/clang/Parse (in this case), but maybe putting them right in clang/lib/Parse/BUILD.gn makes mor sense. (For clang_tablegen() calls that generate .inc files used by the public headers, putting the call in the public BUILD file makes sense.)

For now, I've put the build file in the public header folder, since that matches CMake and what I did in the last 2 clang patches, but I'm not sure I like this.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek accepted this revision.Dec 20 2018, 12:18 PM
This revision is now accepted and ready to land.Dec 20 2018, 12:18 PM
This revision was automatically updated to reflect the committed changes.