This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Correct example PartialMapping table
ClosedPublic

Authored by arsenm on Dec 19 2018, 6:20 PM.

Details

Reviewers
qcolombet
Summary

When I try to use this, it seems like the second half needs
to start where the previous part left off.

Diff Detail

Event Timeline

arsenm created this revision.Dec 19 2018, 6:20 PM

Hi Matt,

You're right.

Your fix is actually not completely correct for the next comments too:

  • The 2x seems weird since the two inputs are on different lines and we would think the comment is meant for this one line alone. Could you have this comment spans the two lines
  • the example with the break down does not match what's in the array any more. You have to fix line 122 (add the partial 32-32) and lines 127-128 too reflect the indices changes.

Thanks for fixing this.
Quentin

arsenm updated this revision to Diff 179185.Dec 20 2018, 3:46 PM

Try again

This revision is now accepted and ready to land.Dec 20 2018, 4:35 PM
arsenm closed this revision.Dec 20 2018, 7:07 PM

r349879